From: "stipa (Code Review)" Date: Fri, 1 Aug 2025 09:33:43 +0000 References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <7280c018eeedd18b6c5fc10c23177dcd5e09cf1b-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="YDXGsIwPHb8="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Log setting DNS via NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --YDXGsIwPHb8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1126?usp=3Demail to review the following change. Change subject: Log setting DNS via NRPT ...................................................................... Log setting DNS via NRPT Unlike other ways of setting DNS, we don't log anything when we use NRPT. Since dco-win/--dns is the recommended configuration and it uses NRPT to set DNS, let's log it. Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b Signed-off-by: Lev Stipakov --- M src/openvpn/dns.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/1126/1 diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c index ea3d91b..e079cd0 100644 --- a/src/openvpn/dns.c +++ b/src/openvpn/dns.c @@ -461,6 +461,11 @@ make_domain_list("dns search domains", search_domains, false, nrpt.search_domains, sizeof(nrpt.search_domains)); + msg(D_LOW, "%s NRPT DNS%s%s on '%s' (if_index =3D %d) using service", + (add ? "Setting" : "Deleting"), nrpt.resolve_domains[0] !=3D 0 ? "= , resolve domains" : "", + nrpt.search_domains[0] !=3D 0 ? ", search domains" : "", + nrpt.iface.name, nrpt.iface.index); + send_msg_iservice(o->msg_channel, &nrpt, sizeof(nrpt), &ack, "DNS"); } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1126?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b Gerrit-Change-Number: 1126 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --YDXGsIwPHb8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

stipa would like plaisthos and flichtenheld to review t= his change.

V= iew Change

Log setting DNS via NRPT

Unlike other ways of setting= DNS, we don't log anything
when we use NRPT. Since dco-win/--dns is= the recommended
configuration and it uses NRPT to set DNS, let's lo= g it.

Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b
Signed= -off-by: Lev Stipakov <lev@...515...>
---
M src/openvpn/dns.c1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh:=
//gerrit.openvpn.net:29418/openvpn refs/changes/26/1126/1
diff --=
git a/src/openvpn/dns.c b/src/openvpn/dns.c
index ea3d91b..= e079cd0 100644
--- a/src/openvpn/dns.c
+++ = b/src/openvpn/dns.c
@@ -461,6 +461,11 @@
= make_domain_list("dns search domains", search_domains, false,<= /span>
nrpt.search_domains, sizeof(nrpt.sear= ch_domains));

+ msg(D_LOW, "%s NRPT DNS%s%s on '%s' (if_index = =3D %d) using service",
+ (add ? "Setting" : "Deleting"), nrpt.r= esolve_domains[0] !=3D 0 ? ", resolve domains" : "",
+ nrpt.search_do= mains[0] !=3D 0 ? ", search domains" : "",
+ nrpt.iface.name, nrpt.if= ace.index);

+<= br> send_msg_iservice(o->msg_channel, &nrpt, sizeof(nrpt),= &ack, "DNS");
}

To view, visit change 1126. To unsubscribe, or for h= elp writing mail filters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f30fe69cb676e347e4d59cd2d= b68db7568ba5b
Gerrit-Change-Number: 1126
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--YDXGsIwPHb8=--