Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95E2C282DE for ; Wed, 5 Jun 2019 06:05:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95DB62075B for ; Wed, 5 Jun 2019 06:05:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95DB62075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:35987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYP36-0003VQ-Fm for qemu-devel@archiver.kernel.org; Wed, 05 Jun 2019 02:05:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYP2A-0003CC-90 for qemu-devel@nongnu.org; Wed, 05 Jun 2019 02:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYP29-0006Zq-7u for qemu-devel@nongnu.org; Wed, 05 Jun 2019 02:04:26 -0400 Received: from mga11.intel.com ([192.55.52.93]:20074) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYP28-0005vS-TJ for qemu-devel@nongnu.org; Wed, 05 Jun 2019 02:04:25 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 23:04:13 -0700 X-ExtLoop1: 1 Received: from txu2-mobl.ccr.corp.intel.com (HELO [10.239.196.142]) ([10.239.196.142]) by orsmga006.jf.intel.com with ESMTP; 04 Jun 2019 23:04:11 -0700 To: Igor Mammedov References: <20190508061726.27631-1-tao3.xu@intel.com> <20190508061726.27631-8-tao3.xu@intel.com> <20190604170456.5b3c198e@redhat.com> From: Tao Xu Message-ID: <729bde4a-bcb9-dac5-3a8a-04cc5f4d2bf9@intel.com> Date: Wed, 5 Jun 2019 14:04:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190604170456.5b3c198e@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.93 Subject: Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com, jingqi.liu@intel.com, qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/4/2019 11:04 PM, Igor Mammedov wrote: > On Wed, 8 May 2019 14:17:22 +0800 > Tao Xu wrote: > >> From: Liu Jingqi >> >> This structure describes memory side cache information for memory >> proximity domains if the memory side cache is present and the >> physical device(SMBIOS handle) forms the memory side cache. >> The software could use this information to effectively place >> the data in memory to maximize the performance of the system >> memory that use the memory side cache. >> >> Signed-off-by: Liu Jingqi >> Signed-off-by: Tao Xu >> --- >> ... >> + >> + /* SMBIOS Handles */ >> + /* TBD: set smbios handles */ >> + build_append_int_noprefix(table_data, 0, 2 * n); > Is memory side cache structure useful at all without pointing to SMBIOS entries? > They are not useful yet, and the kernel 5.1 HMAT sysfs doesn't show SMBIOS entries. We can update it if it useful in the future.