From: Jacek Anaszewski Date: Fri, 20 Sep 2019 19:49:00 +0000 Subject: Re: [PATCH v2] leds-bcm6328: Use devm_platform_ioremap_resource() in bcm6328_leds_probe() Message-Id: <72d7c197-e5ca-d51e-4c36-016147ce3d1c@gmail.com> List-Id: References: <658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring , linux-leds@vger.kernel.org, =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , Dan Murphy , Pavel Machek Cc: LKML , kernel-janitors@vger.kernel.org Hi Markus, Thank you for the updated patch set. Applied to the for-5.5 branch. Best regards, Jacek Anaszewski On 9/20/19 2:40 PM, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Sep 2019 14:30:31 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > > > v2: > > Jacek Anaszewski requested to split updates for two modules > > into a separate patch for each driver. > > https://lore.kernel.org/r/658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com/ > > > > drivers/leds/leds-bcm6328.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c > index c50d34e2b098..42e1b7598c3a 100644 > --- a/drivers/leds/leds-bcm6328.c > +++ b/drivers/leds/leds-bcm6328.c > @@ -346,16 +346,11 @@ static int bcm6328_leds_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *np = pdev->dev.of_node; > struct device_node *child; > - struct resource *mem_r; > void __iomem *mem; > spinlock_t *lock; /* memory lock */ > unsigned long val, *blink_leds, *blink_delay; > > - mem_r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem_r) > - return -EINVAL; > - > - mem = devm_ioremap_resource(dev, mem_r); > + mem = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mem)) > return PTR_ERR(mem); > > -- > 2.23.0 > >