Return-Path: Received: from mail-it1-f195.google.com ([209.85.166.195]:35501 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbeLFTnB (ORCPT ); Thu, 6 Dec 2018 14:43:01 -0500 Received: by mail-it1-f195.google.com with SMTP id p197so3429623itp.0 for ; Thu, 06 Dec 2018 11:43:01 -0800 (PST) Subject: Re: [PATCH 08/26] aio: don't zero entire aio_kiocb aio_get_req() To: Jeff Moyer Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, hch@lst.de References: <20181204233729.26776-1-axboe@kernel.dk> <20181204233729.26776-9-axboe@kernel.dk> <99b52953-091d-007c-43aa-41198b0ed747@kernel.dk> From: Jens Axboe Message-ID: <72e91bed-b135-2d6a-c26a-bf65afed990c@kernel.dk> Date: Thu, 6 Dec 2018 12:42:58 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 12/6/18 12:38 PM, Jeff Moyer wrote: > Jens Axboe writes: > >> On 12/6/18 12:27 PM, Jeff Moyer wrote: >>> Jens Axboe writes: >>> >>>> It's 192 bytes, fairly substantial. Most items don't need to be cleared, >>>> especially not upfront. Clear the ones we do need to clear, and leave >>>> the other ones for setup when the iocb is prepared and submitted. >>> >>> What performance gains do you see from this? >> >> Before this, I had 1% in memset doing high IOPS. With it, that's gone. >> 1% is a lot, when you have just one thread doing everything from submission >> to completion. > > I'm used to customers complaining about fractions of a percent, so I get > it. :-) I just wanted to know we had some measurable impact, as I've > seen bugs crop up from code like this in the past. Oh for sure, I wouldn't do it if there wasn't a noticeable gain from this! -- Jens Axboe