From: Christoph Böhmwalder Date: Sat, 9 Apr 2022 10:15:33 +0200 Subject: [Cluster-devel] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD In-Reply-To: <20220409045043.23593-25-hch@lst.de> References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> Message-ID: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 09.04.22 06:50, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. > > The only places where needs special attention is the RAID5 driver, > which must clear discard support for security reasons by default, > even if the default stacking rules would allow for it. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Christoph B?hmwalder [btrfs] I think you may have a typo there: my ACK was for drbd, not btrfs. > Acked-by: Coly Li [bcache] > --- > arch/um/drivers/ubd_kern.c | 2 -- > block/blk-core.c | 2 +-