From: Jan Stancek Date: Mon, 30 Nov 2015 07:46:12 -0500 (EST) Subject: [LTP] [PATCH] Fix wrong pattern used by fnmatch in test case proc01.c In-Reply-To: <1448606649-141790-2-git-send-email-King.lijin@huawei.com> References: <1448606649-141790-1-git-send-email-King.lijin@huawei.com> <1448606649-141790-2-git-send-email-King.lijin@huawei.com> Message-ID: <733187539.20734579.1448887572067.JavaMail.zimbra@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it ----- Original Message ----- > From: "Li Jin" > To: "king lijin" , ltp@lists.linux.it > Cc: "Li Jin" > Sent: Friday, 27 November, 2015 7:44:09 AM > Subject: [LTP] [PATCH] Fix wrong pattern used by fnmatch in test case proc01.c > > fnmatch() in proc01.c should use pattern ipv6/conf/[a-z]*/stable_secret > to replace /ipv6/conf/*/stable_secret to check the known issue string such as > /proc/sys/net/ipv6/conf/all/stable_secret Hi, An explanation _why_ it is wrong would be helpful too. > > Signed-off-by: Li Jin > --- > testcases/kernel/fs/proc/proc01.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/fs/proc/proc01.c > b/testcases/kernel/fs/proc/proc01.c > index 2825b51..197eb55 100644 > --- a/testcases/kernel/fs/proc/proc01.c > +++ b/testcases/kernel/fs/proc/proc01.c > @@ -107,7 +107,7 @@ static const struct mapping known_issues[] = { > {"read", "/proc/fs/nfsd/.getfs", EINVAL}, > {"read", "/proc/fs/nfsd/.getfd", EINVAL}, > {"read", "/proc/self/net/rpc/use-gss-proxy", EAGAIN}, > - {"read", "/proc/sys/net/ipv6/conf/*/stable_secret", EIO}, > + {"read", "/proc/sys/net/ipv6/conf/[a-z]*/stable_secret", EIO}, This has problems as well: # ip tuntap add 1tap mode tap # ./proc01 -m 128 proc01 0 TINFO : /proc/sys/fs/binfmt_misc/register: is write-only. proc01 1 TFAIL : proc01.c:393: read failed: /proc/sys/net/ipv6/conf/1tap/stable_secret: errno=EIO(5): Input/output error ... How about: + {"read", "/proc/sys/net/ipv6/conf/?*/stable_secret", EIO}, Regards, Jan > {"", "", 0} > }; > > -- > 1.8.3.1 > > > -- > Mailing list info: http://lists.linux.it/listinfo/ltp >