From: "cron2 (Code Review)" Date: Fri, 9 Aug 2024 19:21:04 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <733807cdc6911be1ef141c6e6f1c96bd1872abcb-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="IJHqiLVbELA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use a more robust way to get dco-win version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stipa Cc: plaisthos , flichtenheld , openvpn-devel --IJHqiLVbELA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/723?usp=3Demail ) Change subject: Use a more robust way to get dco-win version ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Looks good. Helps reduce friction (=3D avoid misleading error messages in = log) when multiple programs are active, and possibly multiple DCO interface= s. Matches driver code change. Build errors are due to socks proxy not running, independent of the change = here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/723?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ieb6f3a9d14d76000c1caf8ee1e959c6d0de832bf Gerrit-Change-Number: 723 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Fri, 09 Aug 2024 19:21:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --IJHqiLVbELA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

Patch set 1:Code-Review +2=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      Looks good. Helps reduce friction (=3D avoid = misleading error messages in log) when multiple programs are active, and po= ssibly multiple DCO interfaces. Matches driver code change.

      Build errors are due to soc= ks proxy not running, independent of the change here.

  • To view, visit change 723. To unsubscribe, or for help writing mail filters= , visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ieb6f3a9d14d76000c1caf8ee1e9= 59c6d0de832bf
    Gerrit-Change-Number: 723
    Gerrit-PatchSet: 1
    Gerrit-Owner: stipa <lstipakov@...277...>= ;
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: stipa <lstipakov@...1663...= .>
    Gerrit-Comment-Date: Fri, 09 Aug 2024 19:21:04= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --IJHqiLVbELA=--