From: "cron2 (Code Review)"
Date: Fri, 17 Apr 2026 16:46:29 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227..., matthias.andree@...68...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <7338b9ef8baddde63dba2f100286d39eeb37ba0e-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="61BNxc4ooEI="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: OpenSSL 4.0: Use
X509_check_certificate_times instead of X509_cmp_time
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: mandree , flichtenheld , openvpn-devel
--61BNxc4ooEI=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, mandree, plaisthos.
cron2 has posted comments on this change by plaisthos. ( http://gerrit.open=
vpn.net/c/openvpn/+/1595?usp=3Demail )
Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X5=
09_cmp_time
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
After some quick discussion we didn't feel like doing another round - the A=
PI documentation says "these 4 error codes are possible" and it's hard to i=
magine anything else (a generic "EWEIRDFAILURE" can always be signalled as =
one of the two "cannot read
Not sure whet=
her that is bikeshedding, but should we maybe use a case statement here? Lo=
oks more app [=E2=80=A6]