Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D65714AA6 for ; Thu, 17 Aug 2023 17:44:30 +0000 (UTC) Received: from out-29.mta0.migadu.com (out-29.mta0.migadu.com [91.218.175.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862D5C1 for ; Thu, 17 Aug 2023 10:44:29 -0700 (PDT) Message-ID: <73c939b9-a06b-ee02-f260-39fade8ac1b6@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692294267; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r9Qx8quciZNWg2KVOCgthG5mL9fmHWxa3lun9LVDXCE=; b=WBj8PIcyqUGP15EOE0btcbaSoQTI3J9LnQxpA8TsHNJ3Wa9ruIFpC3G9KdaUTURZp36wD5 8JJBuln8rmi+A9oescuVa7NDcC0I+Dtp/w23hXj5mAHXVsaWwO/2muDCz+pLtWwm0AoVJz vygRbuvfmoUyAUQLaR6xinL5XbJ8wXw= Date: Thu, 17 Aug 2023 10:44:24 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: yonghong.song@linux.dev Subject: Re: Masks and overflow of signed immediates in BPF instructions Content-Language: en-US To: "Jose E. Marchesi" Cc: bpf@vger.kernel.org, david.faust@oracle.com, cupertino.miranda@oracle.com References: <877cpwgzgh.fsf@oracle.com> <87leec44v1.fsf@oracle.com> <87wmxv2ut4.fsf@oracle.com> <878raa14rc.fsf@oracle.com> <92974205-730f-4815-1eda-f8ee8217d8dc@linux.dev> <83e093b1-97ec-14e3-56ee-8258eea66709@linux.dev> <87o7j5wox2.fsf@oracle.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <87o7j5wox2.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 8/17/23 10:37 AM, Jose E. Marchesi wrote: > >> On 8/17/23 9:23 AM, Yonghong Song wrote: >>> On 8/17/23 1:01 AM, Jose E. Marchesi wrote: >>>> >>>>> [...] >>>>> In llvm, for inline asm, 0xfffffffe, 4294967294 and -2 have the same >>>>> 4-byte bit-wise encoding, so they will be all encoded the same >>>>> 0xfffffffe in the actual insn. >>>>> >>>>> The following is an example for x86 target in llvm: >>>>> >>>>> $ cat t.c >>>>> int foo() { >>>>>    int a, b; >>>>> >>>>>    asm volatile("movl $0xfffffffe, %0" : "=r"(a) :); >>>>>    asm volatile("movl $-2, %0" : "=r"(b) :); >>>>>    return a + b; >>>>> } >>>>> $ clang -O2 -c t.c >>>>> $ llvm-objdump -d t.o >>>>> >>>>> t.o:    file format elf64-x86-64 >>>>> >>>>> Disassembly of section .text: >>>>> >>>>> 0000000000000000 : >>>>>         0: b9 fe ff ff ff                movl    $0xfffffffe, %ecx # >>>>>        imm = 0xFFFFFFFE >>>>>         5: b8 fe ff ff ff                movl    $0xfffffffe, %eax # >>>>>        imm = 0xFFFFFFFE >>>>>         a: 01 c8                         addl    %ecx, %eax >>>>>         c: c3                            retq >>>>> $ >>>>> >>>>> Whether it is 0xfffffffe or -2, the insn encoding is the same >>>>> and disasm prints out 0xfffffffe. >>>> >>>> Thanks for the explanation. >>>> >>>> I have pushed the commit below to binutils that makes GAS match the llvm >>>> assembler behavior regarding constant immediates.  With this patch there >>>> are no more assembler errors when building the kernel bpf selftests. >>> Great! Thanks. >>> >>>> >>>> Note however that there is one pending divergence in the behavior of >>>> both assemblers when facing invalid programs where immediate operands >>>> cannot be represented in the number of bits of the field like in: >>>> >>>>    $ cat foo.s >>>>    if r1 > r2 goto 0x3fff1 >>>> >>>> llvm silently truncates it to 16-bit: >>>> >>>>    $ clang -target bpf foo.s >>>>    $ bpf-unkonwn-none-objdump -M pseudoc -dr foo.o >>>>    0000000000000000 <.text>: >>>>       0:    2d 21 f1 ff 00 00 00 00     if r1>r2 goto -15 >>>> >>>> GAS emits an error instead: >>>> >>>>    $ as -mdialect=pseudoc foo.s >>>>    foo.s: Assembler messages: >>>>    foo.s:1: Error: pc-relative offset out of range, shall fit in 16 bits. >>>> >>>> (The same happens with 32-bit immediates.) >>>> >>>> We think the error is pertinent, and we recommend the llvm assembler to >>>> behave the same way. >>> Thanks! We will take a look at this issue soon. >> >> A patch like below can issue the warning for the above case: >> >> diff --git a/llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp >> b/llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp >> index 420a2aad480a..fca6bf30fb4b 100644 >> --- a/llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp >> +++ b/llvm/lib/Target/BPF/MCTargetDesc/BPFMCCodeEmitter.cpp >> @@ -136,6 +136,12 @@ void BPFMCCodeEmitter::encodeInstruction(const >> MCInst &MI, >> OSE.write(0); >> OSE.write(Imm >> 32); >> } else { >> + if (Opcode == BPF::JUGT_rr) { >> + const MCOperand &MO = MI.getOperand(2); >> + int64_t Imm = MO.isImm() ? MO.getImm() : 0; >> + if (Imm > INT16_MAX || Imm < INT16_MIN) > > Shouldn't that be: > > if (Imm > UINT16_MAX || Imm < INT16_MIN) The number 'Imm' represents true offset (positive or negative) as represented in .s file. So positive offset 0xfffffffe cannot be presented. The encoding in insn with 0xfffffffe actually means -2. > > ? > >> + report_fatal_error("Branch target out of insn range"); >> + } >> // Get instruction encoding and emit it >> uint64_t Value = getBinaryCodeForInstr(MI, Fixups, STI); >> CB.push_back(Value >> 56); >> >> Need to generalize to other related conditional/unconditional >> operands. Will have a formal patch for llvm soon. >> >> Thanks. >