Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1o8NtB-0001ld-Ev for mharc-qemu-riscv@gnu.org; Mon, 04 Jul 2022 11:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8NtA-0001jZ-14 for qemu-riscv@nongnu.org; Mon, 04 Jul 2022 11:21:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:32505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Nt7-00029s-5u for qemu-riscv@nongnu.org; Mon, 04 Jul 2022 11:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656948084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oAa20g9OAuQhUxFtb8haoc0C6+H5TmFHdFkWoYZZhpw=; b=Zo9PRbwJ132XCHitKzsAl8XmeCb2h8SyzNhL0NOM/VCLzeiQjRrTGZEazhfIcaTrGuuviA VyXbmADRBwAC+Gqq7N2xulYnaYWWmJjjWTr6W/J+23BS4OIswVeByXbLzHbmpI1HYAcBQa z09ENFSFa0h9lr2V0XGxLWqewziSFhE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-4Xe7kyM7PF64Y-6h0gJMSw-1; Mon, 04 Jul 2022 11:21:23 -0400 X-MC-Unique: 4Xe7kyM7PF64Y-6h0gJMSw-1 Received: by mail-ej1-f70.google.com with SMTP id qf29-20020a1709077f1d00b00722e68806c4so2104131ejc.4 for ; Mon, 04 Jul 2022 08:21:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oAa20g9OAuQhUxFtb8haoc0C6+H5TmFHdFkWoYZZhpw=; b=aknjGCoKrNSfBXHWjCVHMakqKCbjfXMUp6SFrqiL5yRd2e1Xv6J8g07K2F/e6GP/yu ZFtZW+oTWjR6S1RnqtDahgaOOzc/rsSDpbrKeG/51BLxdnKzmRglBqupXdFxooC5d8lQ YuckLu3XBsMjpjKndG4GQCFJEB+XdXJVZQyppN6K71dc0uyIzzcVhM+utvAJrxhvLrEJ 6kv5ssPxquDeNJJuuEV4B21jeyLG+oGD/EmOERycomEM0x6HD36wKGDDfolsenajqyn1 HQHUW34yGz8wQ72u+QOhC+BbMGM/JqwcHcu9PNpomxYSQF51Uy/luBIkAxcU180p0lGv vcgA== X-Gm-Message-State: AJIora/5HJCprstXkC4IyE3Eby3noPFKGBaOoCGm7xJzF6eOH5drmQyn v8XJ/roJjBq/J0yPCGSsnApJfRrP9Luxy6jTxWFRxbZ4QyzlaLFFnXKNK0MdElS4cKx+LlhXSri 1WljfpoZzgv5sAXY= X-Received: by 2002:a05:6402:390b:b0:43a:281e:48fc with SMTP id fe11-20020a056402390b00b0043a281e48fcmr10970244edb.214.1656948082028; Mon, 04 Jul 2022 08:21:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tvHbDJuCW1Ge2PaCADvMVlSyrlAVX1BH5Z3DlkUfV7QzSM9H3C7NHR7mXiohkG5H7iO5CTFQ== X-Received: by 2002:a05:6402:390b:b0:43a:281e:48fc with SMTP id fe11-20020a056402390b00b0043a281e48fcmr10970195edb.214.1656948081840; Mon, 04 Jul 2022 08:21:21 -0700 (PDT) Received: from ?IPV6:2a02:8071:5056:d40:63e3:25a7:c1a1:4455? ([2a02:8071:5056:d40:63e3:25a7:c1a1:4455]) by smtp.gmail.com with ESMTPSA id fi9-20020a170906da0900b00722e5b234basm14391221ejb.179.2022.07.04.08.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 08:21:21 -0700 (PDT) Message-ID: <741358f6-43fd-15d1-86c8-4591cef658bb@redhat.com> Date: Mon, 4 Jul 2022 17:21:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 03/18] block: Change blk_{pread,pwrite}() param order To: Alberto Faria , qemu-devel@nongnu.org Cc: John Snow , Stefan Weil , Andrew Jeffery , Beniamino Galvani , qemu-block@nongnu.org, Fam Zheng , Niek Linnenbank , "Dr. David Alan Gilbert" , Kevin Wolf , Stefan Hajnoczi , Eric Blake , Alistair Francis , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Jeff Cody , Daniel Henrique Barboza , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , "Edgar E. Iglesias" , Juan Quintela , Joel Stanley , Peter Maydell , Laurent Vivier , Bin Meng , Greg Kurz , Vladimir Sementsov-Ogievskiy , qemu-ppc@nongnu.org, Palmer Dabbelt , David Gibson , "Denis V. Lunev" References: <20220517113524.197910-1-afaria@redhat.com> <20220517113746.198993-1-afaria@redhat.com> From: Hanna Reitz In-Reply-To: <20220517113746.198993-1-afaria@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 15:21:28 -0000 On 17.05.22 13:37, Alberto Faria wrote: > Swap 'buf' and 'bytes' around for consistency with > blk_co_{pread,pwrite}(), and in preparation to implement these functions > using generated_co_wrapper. > > Callers were updated using this Coccinelle script: > > @@ expression blk, offset, buf, bytes, flags; @@ > - blk_pread(blk, offset, buf, bytes, flags) > + blk_pread(blk, offset, bytes, buf, flags) > > @@ expression blk, offset, buf, bytes, flags; @@ > - blk_pwrite(blk, offset, buf, bytes, flags) > + blk_pwrite(blk, offset, bytes, buf, flags) > > It had no effect on hw/block/nand.c, presumably due to the #if, so that > file was updated manually. > > Overly-long lines were then fixed by hand. > > Signed-off-by: Alberto Faria > --- > block.c | 2 +- > block/block-backend.c | 4 +-- > block/commit.c | 4 +-- > block/crypto.c | 2 +- > block/export/fuse.c | 4 +-- > block/parallels.c | 2 +- > block/qcow.c | 8 +++--- > block/qcow2.c | 4 +-- > block/qed.c | 8 +++--- > block/vdi.c | 4 +-- > block/vhdx.c | 20 ++++++------- > block/vmdk.c | 10 +++---- > block/vpc.c | 12 ++++---- > hw/arm/allwinner-h3.c | 2 +- > hw/arm/aspeed.c | 2 +- > hw/block/block.c | 2 +- > hw/block/fdc.c | 20 ++++++------- > hw/block/hd-geometry.c | 2 +- > hw/block/m25p80.c | 2 +- > hw/block/nand.c | 47 ++++++++++++++++--------------- > hw/block/onenand.c | 32 ++++++++++----------- > hw/block/pflash_cfi01.c | 4 +-- > hw/block/pflash_cfi02.c | 4 +-- > hw/ide/atapi.c | 4 +-- > hw/misc/mac_via.c | 4 +-- > hw/misc/sifive_u_otp.c | 14 ++++----- > hw/nvram/eeprom_at24c.c | 4 +-- > hw/nvram/spapr_nvram.c | 6 ++-- > hw/nvram/xlnx-bbram.c | 4 +-- > hw/nvram/xlnx-efuse.c | 4 +-- > hw/ppc/pnv_pnor.c | 6 ++-- > hw/sd/sd.c | 4 +-- > include/sysemu/block-backend-io.h | 4 +-- > migration/block.c | 6 ++-- > nbd/server.c | 8 +++--- > qemu-img.c | 18 ++++++------ > qemu-io-cmds.c | 4 +-- > tests/unit/test-block-iothread.c | 8 +++--- > 38 files changed, 150 insertions(+), 149 deletions(-) Reviewed-by: Hanna Reitz