Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7EEC83003 for ; Thu, 30 Apr 2020 02:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB6F02083B for ; Thu, 30 Apr 2020 02:40:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lRNlOttg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgD3CkW (ORCPT ); Wed, 29 Apr 2020 22:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726180AbgD3CkW (ORCPT ); Wed, 29 Apr 2020 22:40:22 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A700C035494 for ; Wed, 29 Apr 2020 19:40:22 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id c63so4334653qke.2 for ; Wed, 29 Apr 2020 19:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f5Ak7oI1eIiRhEKWpiKXEIFPcL2Rb3apHTUCS9FOGPQ=; b=lRNlOttgBSRTPoAeJBxFDZFRoqtDFLaD1ppWg2uL8GnqyUcny8rb9I3dRySviWej/i qsLTVXxkU86FsMfBP9VXRGG6kl4ozNknRniVFHRyr2061oFqUP9j76XCX8ne0QGpxOco inu0uBYmw94lryBJn36xi4m8IjnMM5oFU+zVz3n4WksAaYkVbTU6tKPsiFNbeQFjCJGE p8zslUVgwRSzB5vv4B/b/b/M17LGJgDMjVAKv+C8LHhVidUPouL4k7PZpQirfmxGXJfQ qcNZTrXGdc5+tAfFjUFZflupoRzdshfDR9wdZ9rAxKq7Kd7xtbVFRiv5emVN5sy6/k5e E0Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f5Ak7oI1eIiRhEKWpiKXEIFPcL2Rb3apHTUCS9FOGPQ=; b=r7zQmbWVA88sFsNE92Fqpkznd86cbRmzIC4wSzh4/RaLQxrW2SOLoxo56ldc8Fqb05 bjc2sslm48mO/aNdFXQDvnVxxPZcu4cNbpp21x2yUb9+EtU/P0GEEI8Le44kPt/YiZ07 QkQFumTkSlM+bhP/Y0dN3Gp+snEcPkK07O9baumCGBiaZs0tyQDjmj58OejjKyrQrNLC KoyuKPix/s458822itQ78OHcOno9Iv7XN9l6eL3xMgKdcyaepkbqFc+EkRPgQtAnDtOP GszbbuFbxAKLDP6s1INJxcsIB7iVgdfVRIpfgbt+zl4o/KtH8+LMyPPJiDn7M/P6FcGE DeCg== X-Gm-Message-State: AGi0PuYscpH7OrqvCGRc5wrSXC9/zzw0KNFMJT6N9qV9TsOOMfyBt9SG WgtHQiN38CobjSIi4nj/eE8= X-Google-Smtp-Source: APiQypLF1Z2DZaCgmEWd4ZUOnvdFkQLCO1nT5Noq/NWSTmIQiqLkkp7Ajmx0k238a4WAp2j4OgfMEg== X-Received: by 2002:a05:620a:1458:: with SMTP id i24mr1491902qkl.279.1588214421420; Wed, 29 Apr 2020 19:40:21 -0700 (PDT) Received: from ?IPv6:2601:282:803:7700:ec9c:e6ab:797a:4bad? ([2601:282:803:7700:ec9c:e6ab:797a:4bad]) by smtp.googlemail.com with ESMTPSA id m26sm985337qta.53.2020.04.29.19.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 19:40:20 -0700 (PDT) Subject: Re: [PATCH iproute2-next] erspan: Add type I version 0 support. To: William Tu Cc: Linux Kernel Network Developers , Petr Machata , Xin Long , guy@alum.mit.edu, Dmitriy Andreyevskiy References: <1587913455-78048-1-git-send-email-u9012063@gmail.com> <435b0763-5b7f-fc4b-5490-e6ac36ec0ff0@gmail.com> From: David Ahern Message-ID: <7477680c-4e01-e0b7-c51c-03fcd4c27ad8@gmail.com> Date: Wed, 29 Apr 2020 20:40:18 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/29/20 6:45 PM, William Tu wrote: > On Wed, Apr 29, 2020 at 2:52 PM David Ahern wrote: >> >> On 4/26/20 9:04 AM, William Tu wrote: >>> The Type I ERSPAN frame format is based on the barebones >>> IP + GRE(4-byte) encapsulation on top of the raw mirrored frame. >>> Both type I and II use 0x88BE as protocol type. Unlike type II >>> and III, no sequence number or key is required. >> >> should this be considered a bug fix or -next is what you prefer? >> > Hi David, > Since it's supporting a new type, I'd consider -next. > But either way is ok to me, I don't have have any preference. > Thanks! > William > applied to iproute2-next.