From: Michel Thierry Subject: Re: [PATCH 5/5] drm/i915/icl: Enable RC6 and RPS in Gen11 Date: Thu, 5 Apr 2018 12:42:15 -0700 Message-ID: <7494cc09-5b0e-1f91-4dfa-7d49333f401f@intel.com> References: <20180405140052.10682-1-mika.kuoppala@linux.intel.com> <20180405140052.10682-5-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8841D6E807 for ; Thu, 5 Apr 2018 19:42:16 +0000 (UTC) In-Reply-To: <20180405140052.10682-5-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , "intel-gfx@lists.freedesktop.org" Cc: "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org T24gNC81LzIwMTggNzowMCBBTSwgTWlrYSBLdW9wcGFsYSB3cm90ZToKPiBGcm9tOiBPc2NhciBN YXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IAo+IEFGQUlDVCwgb25jZSB0aGUgbmV3IGlu dGVycnVwdCBpcyBpbiBwbGFjZSwgdGhlIHJlc3Qgc2hvdWxkIGJlaGF2ZSB0aGUKPiBzYW1lIGFz IEdlbjEwLgo+IAo+IHYyOiBVcGRhdGUgcmluZyBmcmVxdWVuY2llcyAoU2FnYXIpCj4gdjM6IFJl YmFzZS4KPiAKPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1 cmlvQGludGVsLmNvbT4KPiBDYzogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGlu dGVsLmNvbT4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KCklmIGl0 J3MgdHJ1ZSB0aGF0IGl0J3MgdGhlIHNhbWUgYXMgR2VuMTAsCgpSZXZpZXdlZC1ieTogTWljaGVs IFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8IDEwICsrKysrLS0tLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BtLmMgICAgIHwgMTAgKysrKy0tLS0tLQo+ICAgMiBmaWxlcyBjaGFu Z2VkLCA5IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggMWRiYTJjNDUxMjU1Li43ODViNzEwZTRlZTQgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0xMjE1LDIwICsxMjE1LDIwIEBA IHN0YXRpYyBpbnQgaTkxNV9mcmVxdWVuY3lfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQg KnVudXNlZCkKPiAgICAgICAgICAgICAgICAgIG1heF9mcmVxID0gKElTX0dFTjlfTFAoZGV2X3By aXYpID8gcnBfc3RhdGVfY2FwID4+IDAgOgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cnBfc3RhdGVfY2FwID4+IDE2KSAmIDB4ZmY7Cj4gICAgICAgICAgICAgICAgICBtYXhfZnJlcSAq PSAoSVNfR0VOOV9CQyhkZXZfcHJpdikgfHwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpID8gR0VOOV9GUkVRX1NDQUxFUiA6IDEpOwo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCA/IEdFTjlf RlJFUV9TQ0FMRVIgOiAxKTsKPiAgICAgICAgICAgICAgICAgIHNlcV9wcmludGYobSwgIkxvd2Vz dCAoUlBOKSBmcmVxdWVuY3k6ICVkTUh6XG4iLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpbnRlbF9ncHVfZnJlcShkZXZfcHJpdiwgbWF4X2ZyZXEpKTsKPiAKPiAgICAgICAgICAgICAg ICAgIG1heF9mcmVxID0gKHJwX3N0YXRlX2NhcCAmIDB4ZmYwMCkgPj4gODsKPiAgICAgICAgICAg ICAgICAgIG1heF9mcmVxICo9IChJU19HRU45X0JDKGRldl9wcml2KSB8fAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgPyBHRU45X0ZSRVFfU0NB TEVSIDogMSk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBJTlRFTF9HRU4oZGV2X3By aXYpID49IDEwID8gR0VOOV9GUkVRX1NDQUxFUiA6IDEpOwo+ICAgICAgICAgICAgICAgICAgc2Vx X3ByaW50ZihtLCAiTm9taW5hbCAoUlAxKSBmcmVxdWVuY3k6ICVkTUh6XG4iLAo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnRlbF9ncHVfZnJlcShkZXZfcHJpdiwgbWF4X2ZyZXEpKTsK PiAKPiAgICAgICAgICAgICAgICAgIG1heF9mcmVxID0gKElTX0dFTjlfTFAoZGV2X3ByaXYpID8g cnBfc3RhdGVfY2FwID4+IDE2IDoKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJwX3N0 YXRlX2NhcCA+PiAwKSAmIDB4ZmY7Cj4gICAgICAgICAgICAgICAgICBtYXhfZnJlcSAqPSAoSVNf R0VOOV9CQyhkZXZfcHJpdikgfHwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgIElTX0NB Tk5PTkxBS0UoZGV2X3ByaXYpID8gR0VOOV9GUkVRX1NDQUxFUiA6IDEpOwo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCA/IEdFTjlfRlJFUV9T Q0FMRVIgOiAxKTsKPiAgICAgICAgICAgICAgICAgIHNlcV9wcmludGYobSwgIk1heCBub24tb3Zl cmNsb2NrZWQgKFJQMCkgZnJlcXVlbmN5OiAlZE1IelxuIiwKPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW50ZWxfZ3B1X2ZyZXEoZGV2X3ByaXYsIG1heF9mcmVxKSk7Cj4gICAgICAgICAg ICAgICAgICBzZXFfcHJpbnRmKG0sICJNYXggb3ZlcmNsb2NrZWQgZnJlcXVlbmN5OiAlZE1Ielxu IiwKPiBAQCAtMTgxMSw3ICsxODExLDcgQEAgc3RhdGljIGludCBpOTE1X3JpbmdfZnJlcV90YWJs ZShzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnVudXNlZCkKPiAKPiAgICAgICAgICBtaW5fZ3B1 X2ZyZXEgPSBycHMtPm1pbl9mcmVxOwo+ICAgICAgICAgIG1heF9ncHVfZnJlcSA9IHJwcy0+bWF4 X2ZyZXE7Cj4gLSAgICAgICBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFL RShkZXZfcHJpdikpIHsKPiArICAgICAgIGlmIChJU19HRU45X0JDKGRldl9wcml2KSB8fCBJTlRF TF9HRU4oZGV2X3ByaXYpID49IDEwKSB7Cj4gICAgICAgICAgICAgICAgICAvKiBDb252ZXJ0IEdU IGZyZXF1ZW5jeSB0byA1MCBIWiB1bml0cyAqLwo+ICAgICAgICAgICAgICAgICAgbWluX2dwdV9m cmVxIC89IEdFTjlfRlJFUV9TQ0FMRVI7Cj4gICAgICAgICAgICAgICAgICBtYXhfZ3B1X2ZyZXEg Lz0gR0VOOV9GUkVRX1NDQUxFUjsKPiBAQCAtMTgyNyw3ICsxODI3LDcgQEAgc3RhdGljIGludCBp OTE1X3JpbmdfZnJlcV90YWJsZShzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnVudXNlZCkKPiAg ICAgICAgICAgICAgICAgIHNlcV9wcmludGYobSwgIiVkXHRcdCVkXHRcdFx0XHQlZFxuIiwKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZWxfZ3B1X2ZyZXEoZGV2X3ByaXYsIChncHVf ZnJlcSAqCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKElTX0dFTjlfQkMoZGV2X3ByaXYpIHx8Cj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgPwo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElO VEVMX0dFTihkZXZfcHJpdikgPj0gMTAgPwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHRU45X0ZSRVFfU0NBTEVSIDogMSkpKSwKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKChpYV9mcmVxID4+IDApICYgMHhmZikgKiAxMDAsCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoaWFfZnJlcSA+PiA4KSAmIDB4ZmYpICogMTAw KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCBhMDE4YzlhYmMyYjkuLjBkMjVlNDEz ZWMwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC02NTcyLDcgKzY1NzIsNyBA QCBzdGF0aWMgdm9pZCBnZW42X2luaXRfcnBzX2ZyZXF1ZW5jaWVzKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAKPiAgICAgICAgICBycHMtPmVmZmljaWVudF9mcmVxID0gcnBz LT5ycDFfZnJlcTsKPiAgICAgICAgICBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJP QURXRUxMKGRldl9wcml2KSB8fAo+IC0gICAgICAgICAgIElTX0dFTjlfQkMoZGV2X3ByaXYpIHx8 IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSB7Cj4gKyAgICAgICAgICAgSVNfR0VOOV9CQyhkZXZf cHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCkgewo+ICAgICAgICAgICAgICAgICAg dTMyIGRkY2Nfc3RhdHVzID0gMDsKPiAKPiAgICAgICAgICAgICAgICAgIGlmIChzYW5keWJyaWRn ZV9wY29kZV9yZWFkKGRldl9wcml2LAo+IEBAIC02NTg1LDcgKzY1ODUsNyBAQCBzdGF0aWMgdm9p ZCBnZW42X2luaXRfcnBzX2ZyZXF1ZW5jaWVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJwcy0+bWF4 X2ZyZXEpOwo+ICAgICAgICAgIH0KPiAKPiAtICAgICAgIGlmIChJU19HRU45X0JDKGRldl9wcml2 KSB8fCBJU19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+ICsgICAgICAgaWYgKElTX0dFTjlfQkMo ZGV2X3ByaXYpIHx8IElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTApIHsKPiAgICAgICAgICAgICAg ICAgIC8qIFN0b3JlIHRoZSBmcmVxdWVuY3kgdmFsdWVzIGluIDE2LjY2IE1IWiB1bml0cywgd2hp Y2ggaXMKPiAgICAgICAgICAgICAgICAgICAqIHRoZSBuYXR1cmFsIGhhcmR3YXJlIHVuaXQgZm9y IFNLTAo+ICAgICAgICAgICAgICAgICAgICovCj4gQEAgLTY5MjMsNyArNjkyMyw3IEBAIHN0YXRp YyB2b2lkIGdlbjZfdXBkYXRlX3JpbmdfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gCj4gICAgICAgICAgbWluX2dwdV9mcmVxID0gcnBzLT5taW5fZnJlcTsKPiAgICAg ICAgICBtYXhfZ3B1X2ZyZXEgPSBycHMtPm1heF9mcmVxOwo+IC0gICAgICAgaWYgKElTX0dFTjlf QkMoZGV2X3ByaXYpIHx8IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSB7Cj4gKyAgICAgICBpZiAo SVNfR0VOOV9CQyhkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCkgewo+ICAg ICAgICAgICAgICAgICAgLyogQ29udmVydCBHVCBmcmVxdWVuY3kgdG8gNTAgSFogdW5pdHMgKi8K PiAgICAgICAgICAgICAgICAgIG1pbl9ncHVfZnJlcSAvPSBHRU45X0ZSRVFfU0NBTEVSOwo+ICAg ICAgICAgICAgICAgICAgbWF4X2dwdV9mcmVxIC89IEdFTjlfRlJFUV9TQ0FMRVI7Cj4gQEAgLTY5 MzgsNyArNjkzOCw3IEBAIHN0YXRpYyB2b2lkIGdlbjZfdXBkYXRlX3JpbmdfZnJlcShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAgICAgICAgICAgICAgICBjb25zdCBpbnQg ZGlmZiA9IG1heF9ncHVfZnJlcSAtIGdwdV9mcmVxOwo+ICAgICAgICAgICAgICAgICAgdW5zaWdu ZWQgaW50IGlhX2ZyZXEgPSAwLCByaW5nX2ZyZXEgPSAwOwo+IAo+IC0gICAgICAgICAgICAgICBp ZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpIHsKPiAr ICAgICAgICAgICAgICAgaWYgKElTX0dFTjlfQkMoZGV2X3ByaXYpIHx8IElOVEVMX0dFTihkZXZf cHJpdikgPj0gMTApIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgLyoKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICogcmluZ19mcmVxID0gMiAqIEdULiByaW5nX2ZyZXEgaXMgaW4gMTAw TUh6IHVuaXRzCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAqIE5vIGZsb29yIHJlcXVpcmVk IGZvciByaW5nIGZyZXF1ZW5jeSBvbiBTS0wuCj4gQEAgLTgxNDQsOCArODE0NCw2IEBAIHN0YXRp YyB2b2lkIGludGVsX2VuYWJsZV9ycHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgICAgICAgICAgICAgICAgY2hlcnJ5dmlld19lbmFibGVfcnBzKGRldl9wcml2KTsKPiAg ICAgICAgICB9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpKSB7Cj4gICAgICAgICAg ICAgICAgICB2YWxsZXl2aWV3X2VuYWJsZV9ycHMoZGV2X3ByaXYpOwo+IC0gICAgICAgfSBlbHNl IGlmIChXQVJOX09OX09OQ0UoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkpIHsKPiAtICAgICAg ICAgICAgICAgLyogVE9ETyAqLwo+ICAgICAgICAgIH0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSA5KSB7Cj4gICAgICAgICAgICAgICAgICBnZW45X2VuYWJsZV9ycHMoZGV2X3ByaXYp Owo+ICAgICAgICAgIH0gZWxzZSBpZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+IC0tCj4g Mi4xNC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=