Message-ID: <74ca6b40-220d-f731-7c16-3e3e35bba8e9@...1227...> Date: Thu, 15 Dec 2022 23:52:14 +0100 MIME-Version: 1.0 From: Arne Schwabe References: <20221215190143.2107896-1-arne@...1227...> <20221215190143.2107896-3-arne@...1227...> In-Reply-To: <20221215190143.2107896-3-arne@...1227...> Subject: Re: [Openvpn-devel] [PATCH 2/8] ssl_verify: Fix memleak if creating deferred auth control files fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net Cc: David Sommerseth Am 15.12.2022 um 20:01 schrieb Arne Schwabe: > From: David Sommerseth > > If the key_state_gen_auth_control_files() call fails, the code would > just return without freeing the argv container. Instead the code should > jump to an appropriate exit point where memory is being released. > > Also adjust the related comment, to indicate that these deferred auth > control files are really pre-created. > > Signed-off-by: David Sommerseth > > Reported-by: Trial of Bits (TOB-OVPN-2) Typo here: Should be Trail of Bits (my mistake)