Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AD6C4742C for ; Mon, 16 Nov 2020 10:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 926A12054F for ; Mon, 16 Nov 2020 10:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728207AbgKPJd0 (ORCPT ); Mon, 16 Nov 2020 04:33:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:57548 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728181AbgKPJd0 (ORCPT ); Mon, 16 Nov 2020 04:33:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5ADF7AFEB; Mon, 16 Nov 2020 09:33:24 +0000 (UTC) Subject: Re: [PATCH V4 04/12] sbitmap: move allocation hint into sbitmap To: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: Omar Sandoval , Kashyap Desai , Sumanesh Samanta , "Ewan D . Milne" References: <20201116090737.50989-1-ming.lei@redhat.com> <20201116090737.50989-5-ming.lei@redhat.com> From: Hannes Reinecke Message-ID: <74d2671e-5648-cbc0-74fd-e4cebf4fb452@suse.de> Date: Mon, 16 Nov 2020 10:33:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201116090737.50989-5-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/16/20 10:07 AM, Ming Lei wrote: > Allocation hint should have belonged to sbitmap, also when sbitmap's > depth is high and no need to use mulitple wakeup queues, user can > benefit from percpu allocation hint too. > > So move allocation hint into sbitmap, then scsi device queue can benefit > from allocation hint when converting to plain sbitmap in the following > patches. > > Cc: Omar Sandoval > Cc: Kashyap Desai > Cc: Sumanesh Samanta > Cc: Ewan D. Milne > Cc: Hannes Reinecke > Tested-by: Sumanesh Samanta > Signed-off-by: Ming Lei > --- > block/blk-mq.c | 2 +- > block/kyber-iosched.c | 2 +- > include/linux/sbitmap.h | 41 +++++++++------ > lib/sbitmap.c | 112 +++++++++++++++++++++++----------------- > 4 files changed, 94 insertions(+), 63 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer