References: <20161216182659.18194-1-jm@...1926...> From: Arne Schwabe Message-ID: <753a3322-c5ea-758e-6298-a12f0e772896@...1227...> Date: Fri, 16 Dec 2016 22:53:34 +0100 MIME-Version: 1.0 In-Reply-To: <20161216182659.18194-1-jm@...1926...> Subject: Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Julien Muchembled , openvpn-devel@lists.sourceforge.net Cc: kirr@...1926... Am 16.12.16 um 19:26 schrieb Julien Muchembled: > The bug in Trac #792 (pointer wrongly truncated as 'int', leading to segfaults) > would have been understood faster with either > -Werror=implicit or -Werror=format > (and above all, before running buggy executables in production) > > Debian already compiles with -Werror=format-security, and it's indeed a good > idea for a sensitive software like OpenVPN to use it. > --- >> Yes, please! >> >> You can put the macro in m4/ >> > > OK. Not sure about the license. It's GPL3+ We cannot accept GPL3+ since it is incompatible with our license (GPL2). Arne