From: "flichtenheld (Code Review)" Date: Fri, 22 Aug 2025 13:45:24 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <759fba310e838c1154578e1d9d945d531ea5be5a-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="koCdxtI6XJA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: options: Fix --hash-size virtual argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --koCdxtI6XJA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=3Demail to review the following change. Change subject: options: Fix --hash-size virtual argument ...................................................................... options: Fix --hash-size virtual argument Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all). Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13 Signed-off-by: Frank Lichtenheld --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/1149/1 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 5f9971c..e9584a8 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size =3D real; - options->virtual_hash_size =3D real; + options->virtual_hash_size =3D virtual; } else if (streq(p[0], "connect-freq") && p[1] && p[2] && !p[3]) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13 Gerrit-Change-Number: 1149 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --koCdxtI6XJA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

options: Fix --hash-size virtual argument

Previously = we ignored the second argument to --hash-size.
This bug is older than th= e openvpn git repository, but
clearly this is not an option often used (= or at all).

Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
= Signed-off-by: Frank Lichtenheld <frank@...2641...>
---
M src/o= penvpn/options.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/1149/1
<=
span>diff --git a/src/openvpn/options.c b/src/openvpn/options.c
<= span>index 5f9971c..e9584a8 100644
--- a/src/openvpn/option= s.c
+++ b/src/openvpn/options.c
@@ -7951,7 = +7951,7 @@
goto err;
= }
options->real_hash_size =3D real;
<= span style=3D"color: hsl(0, 100%, 40%);">- options->virtual_hash_= size =3D real;
+ = options->virtual_hash_size =3D virtual;
}=
else if (streq(p[0], "connect-freq") && p[= 1] && p[2] && !p[3])
{

To view, visit change 1149. To unsubscribe, or for help wr= iting mail filters, visit se= ttings.

<= div itemscope itemprop=3D"action" itemtype=3D"http://schema.org/ViewAction"= >
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e795147760= 42bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--koCdxtI6XJA=--