Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=219.87.191.90; helo=mx01.quantatw.com; envelope-from=prvs=981a4a1c7=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx01.quantatw.com (mx01.quantatw.com [219.87.191.90]) by lists.ozlabs.org (Postfix) with ESMTP id 44T9zn0slxzDqDS for ; Tue, 26 Mar 2019 23:53:39 +1100 (AEDT) Received: from unknown (HELO mailbx05.quanta.corp) ([10.243.91.100]) by mx01.quantatw.com with ESMTP; 26 Mar 2019 20:53:35 +0800 Received: from mailbx05.quanta.corp (10.243.91.100) by mailbx05.quanta.corp (10.243.91.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 26 Mar 2019 20:53:34 +0800 Received: from mailbx05.quanta.corp ([fe80::34d4:593b:40f8:a9bc]) by mailbx05.quanta.corp ([fe80::34d4:593b:40f8:a9bc%4]) with mapi id 15.01.1713.004; Tue, 26 Mar 2019 20:53:34 +0800 From: =?big5?B?SGFuayBMaW91ICi8Qq7Kv6sp?= To: "openbmc@lists.ozlabs.org" Subject: [phosphor-pid-control] discuss the code in /pid/buildjson.cpp Thread-Topic: [phosphor-pid-control] discuss the code in /pid/buildjson.cpp Thread-Index: AQHU49It+E8nyHkZWkix+kYaqumljQ== Date: Tue, 26 Mar 2019 12:53:34 +0000 Message-ID: <75d8c71fe0684d6ebc3710bada61b79f@quantatw.com> Accept-Language: en-US, zh-TW Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] x-tm-as-product-ver: SMEX-12.0.0.1727-8.200.1013-24510.006 x-tm-as-result: No-0.357800-0.000000-31 x-tm-as-matchedid: 111600-111604-188119-705718-701827-702638-111605-700074-7 00264-700732-700345-700450-138503-700949-188116-700057-187067-704496-701604 -861059-709584-701747-863519-188144-111601-148004-148050-42000-63 x-tm-as-user-approved-sender: Yes x-tm-as-user-blocked-sender: No Content-Type: multipart/alternative; boundary="_000_75d8c71fe0684d6ebc3710bada61b79fquantatwcom_" MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 12:53:42 -0000 --_000_75d8c71fe0684d6ebc3710bada61b79fquantatwcom_ Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: base64 SGkgYWxsLA0KDQpTb3JyeSBmb3IgaW5zdWZmaWNpZW50IGluZm8gYWJvdXQgbXkgcXVlc3Rpb24u DQoNCkkgYW0gcmVhZGluZyB0aGUgc291cmNlIGNvZGUgb2YgL3BpZC9idWlsZGpzb24uY3BwIGlu IHBob3NwaG9yLXBpZC1jb250cm9sLg0KDQoNCklzIHRoZXJlIGFuIGVycm9yIGluIGxpbmUgNTkg YW5kIDY5PyBUbyBiZSBwcmVjaXNlLCBJIHRoaW5rIGogc2hvdWxkIGJlIHAgc2luY2Ugb25seSBw IGhhcyBlbGVtZW50cyBwb3NpdGl2ZUh5c3RlcmVzaXMgYW5kIG5lZ2F0aXZlSHlzdGVyZXNpcy4N Cg0KU2luY2VyZWx5LA0KDQpIYW5rIExpb3UNClF1YW50YSBDb21wdXRlciBJbmMuDQo= --_000_75d8c71fe0684d6ebc3710bada61b79fquantatwcom_ Content-Type: text/html; charset="big5" Content-Transfer-Encoding: quoted-printable

Hi all,

Sorry for insufficient info about my question.

I am reading the source code of /pid/buildjson.cpp in = phosphor-pid-control. 


Is there an error in line 59 and 69? To be precise,= I think j should be p since only p has elements positiveHysteresis and neg= ativeHysteresis.

Sincerely,

Hank Liou
Quanta Computer Inc.

--_000_75d8c71fe0684d6ebc3710bada61b79fquantatwcom_--