From: Markus Elfring Date: Tue, 05 May 2020 08:15:05 +0000 Subject: Re: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume() Message-Id: <75dd05b8-7895-e1cf-2c76-2327aa11f033@web.de> List-Id: References: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christophe Jaillet , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Hans Verkuil , Jernej Skrabec , Mauro Carvalho Chehab , Maxime Ripard > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. Can it be that the usage of the word “suspicious” would be more appropriate for such a change description? > Re-order the error handling path to avoid it. Would it be also helpful to explicitly mention in the commit message that you would like to move a call of the function “clk_rate_exclusive_put” to the end of this function implementation for the correction of the desired exception handling? Regards, Markus