From: "Souza, Jose" Subject: Re: [PATCH 05/17] drm/i915/debugfs: switch to kernel types Date: Thu, 17 Jan 2019 00:29:13 +0000 Message-ID: <75faed46ab03ecdaa89909c04ef7270828a203fa.camel@intel.com> References: <4d71ed8a432b4121516049334512d35623c8acaa.1547629303.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1573247562==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC5366E258 for ; Thu, 17 Jan 2019 00:29:15 +0000 (UTC) In-Reply-To: <4d71ed8a432b4121516049334512d35623c8acaa.1547629303.git.jani.nikula@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Nikula, Jani" List-Id: intel-gfx@lists.freedesktop.org --===============1573247562== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-5tmrIv3EWmCqzI2E3Hf3" --=-5tmrIv3EWmCqzI2E3Hf3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-01-16 at 11:15 +0200, Jani Nikula wrote: > Mixed C99 and kernel types use is getting ugly. Prefer kernel > types. >=20 > sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g' Reviewed-by: Jos=C3=A9 Roberto de Souza >=20 > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_debugfs.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c > b/drivers/gpu/drm/i915/i915_debugfs.c > index 8d738e6ca7b5..fc78e45778b5 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2249,7 +2249,7 @@ static void i915_guc_client_info(struct > seq_file *m, > { > struct intel_engine_cs *engine; > enum intel_engine_id id; > - uint64_t tot =3D 0; > + u64 tot =3D 0; > =20 > seq_printf(m, "\tPriority %d, GuC stage index: %u, PD offset > 0x%x\n", > client->priority, client->stage_id, client- > >proc_desc_offset); > @@ -3637,7 +3637,7 @@ static int > i915_displayport_test_type_show(struct seq_file *m, void *data) > } > DEFINE_SHOW_ATTRIBUTE(i915_displayport_test_type); > =20 > -static void wm_latency_show(struct seq_file *m, const uint16_t > wm[8]) > +static void wm_latency_show(struct seq_file *m, const u16 wm[8]) > { > struct drm_i915_private *dev_priv =3D m->private; > struct drm_device *dev =3D &dev_priv->drm; > @@ -3680,7 +3680,7 @@ static void wm_latency_show(struct seq_file *m, > const uint16_t wm[8]) > static int pri_wm_latency_show(struct seq_file *m, void *data) > { > struct drm_i915_private *dev_priv =3D m->private; > - const uint16_t *latencies; > + const u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -3695,7 +3695,7 @@ static int pri_wm_latency_show(struct seq_file > *m, void *data) > static int spr_wm_latency_show(struct seq_file *m, void *data) > { > struct drm_i915_private *dev_priv =3D m->private; > - const uint16_t *latencies; > + const u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -3710,7 +3710,7 @@ static int spr_wm_latency_show(struct seq_file > *m, void *data) > static int cur_wm_latency_show(struct seq_file *m, void *data) > { > struct drm_i915_private *dev_priv =3D m->private; > - const uint16_t *latencies; > + const u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -3753,12 +3753,12 @@ static int cur_wm_latency_open(struct inode > *inode, struct file *file) > } > =20 > static ssize_t wm_latency_write(struct file *file, const char __user > *ubuf, > - size_t len, loff_t *offp, uint16_t > wm[8]) > + size_t len, loff_t *offp, u16 wm[8]) > { > struct seq_file *m =3D file->private_data; > struct drm_i915_private *dev_priv =3D m->private; > struct drm_device *dev =3D &dev_priv->drm; > - uint16_t new[8] =3D { 0 }; > + u16 new[8] =3D { 0 }; > int num_levels; > int level; > int ret; > @@ -3803,7 +3803,7 @@ static ssize_t pri_wm_latency_write(struct file > *file, const char __user *ubuf, > { > struct seq_file *m =3D file->private_data; > struct drm_i915_private *dev_priv =3D m->private; > - uint16_t *latencies; > + u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -3818,7 +3818,7 @@ static ssize_t spr_wm_latency_write(struct file > *file, const char __user *ubuf, > { > struct seq_file *m =3D file->private_data; > struct drm_i915_private *dev_priv =3D m->private; > - uint16_t *latencies; > + u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -3833,7 +3833,7 @@ static ssize_t cur_wm_latency_write(struct file > *file, const char __user *ubuf, > { > struct seq_file *m =3D file->private_data; > struct drm_i915_private *dev_priv =3D m->private; > - uint16_t *latencies; > + u16 *latencies; > =20 > if (INTEL_GEN(dev_priv) >=3D 9) > latencies =3D dev_priv->wm.skl_latency; > @@ -4851,7 +4851,7 @@ static int i915_dpcd_show(struct seq_file *m, > void *data) > struct drm_connector *connector =3D m->private; > struct intel_dp *intel_dp =3D > enc_to_intel_dp(&intel_attached_encoder(connector)- > >base); > - uint8_t buf[16]; > + u8 buf[16]; > ssize_t err; > int i; > =20 --=-5tmrIv3EWmCqzI2E3Hf3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlw/zFcACgkQVenbO/mO Wklo6Af/cD+l4vcleeFbPev0jJr7D+mab637JKrShnnLGRgW3t+n1hGH7EbHRgcc 6CQyZamIb7TKC6mmCMW+c5C2fwEvlVe9ydZtcHPH/CaCKyzxlIpSp4TG80QDmzPm Bs2RkRh/Y7cdiatv960Fjt8gUTQVw/bTKaUk5/W4/3hUHUEiomFFvfARbVJ6fp8A IwaBLPZtUKAx0wFdfV63k3wjtOZMvq3i7bx7sw2WMjO8o7qIv1ZvmXIh5O30EfqO 9WBTuDtKJiIWYg1rfAA1k+7+bXVyJzmECIyvQ2LfhgNuNdTxe9S63orpGyPD+7hO wwcj6fJnOJaJVEzs+CrlWzi1klnQdA== =+z6K -----END PGP SIGNATURE----- --=-5tmrIv3EWmCqzI2E3Hf3-- --===============1573247562== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1573247562==--