Message-ID: <761e5640-6d43-d25b-4845-25698d2e0688@...2181...> Date: Wed, 27 Apr 2022 09:55:24 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220427074828.6283-1-kprovost@...2661...> <20220427074828.6283-2-kprovost@...2661...> From: Antonio Quartulli In-Reply-To: <20220427074828.6283-2-kprovost@...2661...> Subject: Re: [Openvpn-devel] [PATCH] Handle (DCO) timeouts in client mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Kristof Provost , openvpn-devel , Lev Stipakov Hi Kristof, On 27/04/2022 09:48, Kristof Provost via Openvpn-devel wrote: > From: Kristof Provost > > Handle the DCO driver telling us that the peer went away, even if we're > not running in multi-instance mode. thanks for catching and fixing this. It was indeed on the todo list, but well hidden under the rest :-D > > Signed-off-by: Kristof Provost > --- > src/openvpn/forward.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c > index 9ddea439..f60c56a8 100644 > --- a/src/openvpn/forward.c > +++ b/src/openvpn/forward.c > @@ -1111,6 +1111,12 @@ process_incoming_dco(struct context *c) > > dco_do_read(dco); > > + if (dco->dco_message_type == OVPN_NOTIF_DEL_PEER) Not sure where this constant is coming from, but on ovpn_dco_linux.h we have OVPN_CMD_DEL_PEER (similar format as the following OVPN_CMD_PACKET). Is that a format we can adhere to on BSD as well? @Lev, just a heads up: does dco-win deal with this case? It would be good to have a look on your side too. Regards, > + { > + trigger_ping_timeout_signal(c); > + return; > + } > + > if (dco->dco_message_type != OVPN_CMD_PACKET) > { > msg(D_DCO_DEBUG, "%s: received message of type %u - ignoring", __func__, -- Antonio Quartulli