Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EDFBC433DB for ; Wed, 3 Feb 2021 00:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5029864F75 for ; Wed, 3 Feb 2021 00:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232457AbhBCAu5 (ORCPT ); Tue, 2 Feb 2021 19:50:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbhBCAuz (ORCPT ); Tue, 2 Feb 2021 19:50:55 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78EF5C061573 for ; Tue, 2 Feb 2021 16:50:15 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id m12so3374136pjs.4 for ; Tue, 02 Feb 2021 16:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squareup.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WrIVK8sDseMlS4o9lz0V6MRsGpJ6jWjlISOO9cArdaE=; b=SWSiiHtZvYGMNzfqn0C705T+byGm0SCksZTFqTryqHaM/C6AJ2+ZFyZfH977qTEzUb S+fzKzvzpBfi9CqT6vS20/vSqQ3Pgf9kx+tWZTe7I7oF+n7AL3aNgDDxxV/YNFIDK463 IDXak76GlG862GDExIWJUcWa9x1fedwPFH+1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WrIVK8sDseMlS4o9lz0V6MRsGpJ6jWjlISOO9cArdaE=; b=NY4oy4MXLUl6T/tiofVfFMsR9udwjHljjvGdts+UAAI7iZ1P4BgInlVT+M19Imc8fW XoZmO5FxBwRyjn+mu115BToysiK55ouwU05Au/k9WHzY15qo7lH3fQYCGFsHC3pgyhQs /RmVchB3miJvbEiMYCHf9774dso1JF/zZUl4KAaMwmK3D18DPj2lnh29xzI/4J7dKb6h jUm1TFbLTnGX504oPldkoH9TzizREiStBFDjHAQBE1iZS/cdi7YtXjj5NYC0mYmbi56j yewxF/pJE3ZShZz3A5horxHvVWS3CZimWZNhe2EYdd1Zzktfi1NCGp+xmzBeEAn3q61J 3yaw== X-Gm-Message-State: AOAM532eEVF2Q51SrTzepkOfgvk3UIkCZqam/SVQy4IFRP3J34gFIZWf lNztQ+o4ph5ltxMYmK4T6TnBDw== X-Google-Smtp-Source: ABdhPJwUtVndBlHghaUzgOXZqCD8uLRkChgDzib4W7gmbknEoDqpUtRqOAYHnIJg9ki5c/5sOFwvKQ== X-Received: by 2002:a17:902:a614:b029:e1:5b43:956a with SMTP id u20-20020a170902a614b02900e15b43956amr846276plq.38.1612313415034; Tue, 02 Feb 2021 16:50:15 -0800 (PST) Received: from benl-m5lvdt.local ([2600:1700:87d0:94f:dd59:3fb8:f6a9:fc02]) by smtp.gmail.com with ESMTPSA id z11sm169589pfk.97.2021.02.02.16.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 16:50:14 -0800 (PST) Subject: Re: [PATCH v2 5/5] interconnect: qcom: Add MSM8939 interconnect provider driver To: Georgi Djakov , Vincent Knecht , Jun Nie , devicetree@vger.kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org Cc: shawn.guo@linaro.org References: <20201204075345.5161-1-jun.nie@linaro.org> <20201204075345.5161-6-jun.nie@linaro.org> From: Benjamin Li Message-ID: <7630c4aa-b023-55a6-e2aa-37a7538c6b45@squareup.com> Date: Tue, 2 Feb 2021 16:50:12 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1/5/21 5:54 AM, Georgi Djakov wrote: > On 1/2/21 13:08, Vincent Knecht wrote: >> Le vendredi 04 décembre 2020 à 15:53 +0800, Jun Nie a écrit : >>> Add driver for the Qualcomm interconnect buses found in MSM8939 based >>> platforms. The topology consists of four NoCs that are controlled by >>> a remote processor that collects the aggregated bandwidth for each >>> master-slave pairs. >>> >>> Signed-off-by: Jun Nie >> >> Shouldn't some rpm ids be changed like they were for msm8916 in the following patch ? >> c497f9322af9 ("interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes") >> https://patchwork.kernel.org/project/linux-arm-msm/patch/20201112105140.10092-1-georgi.djakov@linaro.org/ > > Maybe they should. I don't have the hardware to try it, but the test will be > to just add the NoC DT nodes, enable the driver and inspect the boot log for > messages like: > [    2.926647] qcom_icc_rpm_smd_send mas X error -6 > > Thanks, > Georgi Hi Vincent & Georgi, Thanks, I ran your suggestion on an MSM8939 board (with an additional change to print slave IDs as well). Results: [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6 [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6 [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6 [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6 [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6 [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6 [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6 [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6 (and there's another slv 131 that's hidden by the mas 100 failure) Jun, I'll send you the patch I tested with to silence all these errors, if you want to just squash that into the next version of your patchset. Ben