From: "plaisthos (Code Review)" Date: Wed, 25 Mar 2026 13:30:37 +0000 References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <7683bef195f08412eecca9d7e360ace586435ebe-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="pXf8mrAcqeM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openvpn-devel --pXf8mrAcqeM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/= c/openvpn/+/1587?usp=3Demail ) Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certifica= te usage ...................................................................... Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes. The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1. Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Signed-off-by: Arne Schwabe --- M src/openvpn/ssl_verify_openssl.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/1 diff --git a/src/openvpn/ssl_verify_openssl.c b/src/openvpn/ssl_verify_open= ssl.c index 46401cd..fc14789 100644 --- a/src/openvpn/ssl_verify_openssl.c +++ b/src/openvpn/ssl_verify_openssl.c @@ -626,7 +626,8 @@ { ASN1_BIT_STRING *ns; ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NUL= L, NULL); - result =3D (ns && ns->length > 0 && (ns->data[0] & NS_SSL_CLIE= NT)) ? SUCCESS : FAILURE; + // bit 0 is to check if certificate is the client certificate + result =3D ASN1_BIT_STRING_get_bit(ns, 0) ? SUCCESS : FAILURE; if (result =3D=3D SUCCESS) { msg(M_WARN, "X509: Certificate is a client certificate yet= it's purpose " @@ -652,9 +653,9 @@ */ if (result =3D=3D FAILURE) { - ASN1_BIT_STRING *ns; - ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NUL= L, NULL); - result =3D (ns && ns->length > 0 && (ns->data[0] & NS_SSL_SERV= ER)) ? SUCCESS : FAILURE; + ASN1_BIT_STRING *ns =3D X509_get_ext_d2i(peer_cert, NID_netsca= pe_cert_type, NULL, NULL); + // Server bit is 1 for ASN1_BIT_STRING_get_bit + result =3D ASN1_BIT_STRING_get_bit(ns, 1) ? SUCCESS : FAILURE; if (result =3D=3D SUCCESS) { msg(M_WARN, "X509: Certificate is a server certificate yet= it's purpose " -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Gerrit-Change-Number: 1587 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-CC: openvpn-devel --pXf8mrAcqeM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

plaisthos has upl= oaded this change for review.

View Change

Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
=
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead<= br>of accessing the internal, we have to use a method now to check theseattributes.

The bit counting in ANS.1 and of this method is a bit s= trange and
it will count bits from the left instead of the right, so the= previous
mask of 0x80 for clients is now 0 and 0x40 for server is now 1= .

Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Signed-off= -by: Arne Schwabe <arne@...1227...>
---
M src/openvpn/ssl_verif= y_openssl.c
1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes=
/87/1587/1
diff --git a/src/openvpn/ssl_verify_openssl.c b/src/open=
vpn/ssl_verify_openssl.c
index 46401cd..fc14789 100644
--- a/src/openvpn/ssl_verify_openssl.c
+++ b/sr= c/openvpn/ssl_verify_openssl.c
@@ -626,7 +626,8 @@ {
ASN1_BIT_STRING *ns;=
ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert= _type, NULL, NULL);
- = result =3D (ns && ns->length > 0 && (ns->= ;data[0] & NS_SSL_CLIENT)) ? SUCCESS : FAILURE;
+ // bit 0 is to check if certi= ficate is the client certificate
+ result =3D ASN1_BIT_STRING_get_bit(ns, 0) ? SUCCES= S : FAILURE;
if (result =3D=3D SUCCESS)=
{
msg(M_WARN, "= ;X509: Certificate is a client certificate yet it's purpose "
@@ -652,9 +653,9 @@
*/
if (result =3D=3D FAILURE)

{
= - ASN1_BIT_STRING *ns;=
- ns =3D X5= 09_get_ext_d2i(peer_cert, NID_netscape_cert_type, NULL, NULL);
- result =3D (ns &&a= mp; ns->length > 0 && (ns->data[0] & NS_SSL_SERVER)) ?= SUCCESS : FAILURE;

+= ASN1_BIT_STRING *ns =3D X509_get_ext_d2i(peer_cert, NID_netscap= e_cert_type, NULL, NULL);
+ // Server bit is 1 for ASN1_BIT_STRING_get_bit
= + result =3D ASN1_BI= T_STRING_get_bit(ns, 1) ? SUCCESS : FAILURE;
i= f (result =3D=3D SUCCESS)
{
= msg(M_WARN, "X509: Certificate is a server certificate = yet it's purpose "

To view, vi= sit chan= ge 1587. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca0= 7d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --pXf8mrAcqeM=--