From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count Date: Wed, 24 Oct 2018 09:45:50 +0200 Message-ID: <7690cf4c-5eff-85e4-885c-2ecc9dc01c25@gmail.com> References: <20181023190733.15251-1-maraeo@gmail.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181023190733.15251-1-maraeo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, "Daenzer, Michel" VGhhdCBsb29rcyByZWFsbHkgdWdseSB0byBtZS4gTWFwcGluZyB0aGUgc2FtZSBCTyBzbyBvZnRl biBpcyBpbGxlZ2FsIAphbmQgc2hvdWxkIGJlIGhhbmRsZWQgYXMgZXJyb3IuCgpPdGhlcndpc2Ug d2Ugd2lsbCBuZXZlciBiZSBhYmxlIHRvIGNsZWFubHkgcmVjb3ZlciBmcm9tIGEgR1BVIGxvY2t1 cCAKd2l0aCBsb3N0IHN0YXRlIGJ5IHJlbG9hZGluZyB0aGUgY2xpZW50IGxpYnJhcnkuCgpDaHJp c3RpYW4uCgpBbSAyMy4xMC4xOCB1bSAyMTowNyBzY2hyaWViIE1hcmVrIE9sxaHDoWs6Cj4gRnJv bTogTWFyZWsgT2zFocOhayA8bWFyZWsub2xzYWtAYW1kLmNvbT4KPgo+IC0tLQo+ICAgYW1kZ3B1 L2FtZGdwdV9iby5jIHwgMTkgKysrKysrKysrKysrKysrKystLQo+ICAgMSBmaWxlIGNoYW5nZWQs IDE3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvYW1kZ3B1 L2FtZGdwdV9iby5jIGIvYW1kZ3B1L2FtZGdwdV9iby5jCj4gaW5kZXggYzBmNDJlODEuLjgxZjhh NWY3IDEwMDY0NAo+IC0tLSBhL2FtZGdwdS9hbWRncHVfYm8uYwo+ICsrKyBiL2FtZGdwdS9hbWRn cHVfYm8uYwo+IEBAIC0yMiwyMCArMjIsMjEgQEAKPiAgICAqCj4gICAgKi8KPiAgIAo+ICAgI2lu Y2x1ZGUgPHN0ZGxpYi5oPgo+ICAgI2luY2x1ZGUgPHN0ZGlvLmg+Cj4gICAjaW5jbHVkZSA8c3Rk aW50Lmg+Cj4gICAjaW5jbHVkZSA8c3RyaW5nLmg+Cj4gICAjaW5jbHVkZSA8ZXJybm8uaD4KPiAg ICNpbmNsdWRlIDxmY250bC5oPgo+ICAgI2luY2x1ZGUgPHVuaXN0ZC5oPgo+ICsjaW5jbHVkZSA8 bGltaXRzLmg+Cj4gICAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+Cj4gICAjaW5jbHVkZSA8c3lzL21t YW4uaD4KPiAgICNpbmNsdWRlIDxzeXMvdGltZS5oPgo+ICAgCj4gICAjaW5jbHVkZSAibGliZHJt X21hY3Jvcy5oIgo+ICAgI2luY2x1ZGUgInhmODZkcm0uaCIKPiAgICNpbmNsdWRlICJhbWRncHVf ZHJtLmgiCj4gICAjaW5jbHVkZSAiYW1kZ3B1X2ludGVybmFsLmgiCj4gICAjaW5jbHVkZSAidXRp bF9tYXRoLmgiCj4gICAKPiBAQCAtNDQyLDIxICs0NDMsMjkgQEAgZHJtX3B1YmxpYyBpbnQgYW1k Z3B1X2JvX2NwdV9tYXAoYW1kZ3B1X2JvX2hhbmRsZSBibywgdm9pZCAqKmNwdSkKPiAgIHsKPiAg IAl1bmlvbiBkcm1fYW1kZ3B1X2dlbV9tbWFwIGFyZ3M7Cj4gICAJdm9pZCAqcHRyOwo+ICAgCWlu dCByOwo+ICAgCj4gICAJcHRocmVhZF9tdXRleF9sb2NrKCZiby0+Y3B1X2FjY2Vzc19tdXRleCk7 Cj4gICAKPiAgIAlpZiAoYm8tPmNwdV9wdHIpIHsKPiAgIAkJLyogYWxyZWFkeSBtYXBwZWQgKi8K PiAgIAkJYXNzZXJ0KGJvLT5jcHVfbWFwX2NvdW50ID4gMCk7Cj4gLQkJYm8tPmNwdV9tYXBfY291 bnQrKzsKPiArCj4gKwkJLyogSWYgdGhlIGNvdW50ZXIgaGFzIGFscmVhZHkgcmVhY2hlZCBJTlRf TUFYLCBkb24ndCBpbmNyZW1lbnQKPiArCQkgKiBpdCBhbmQgYXNzdW1lIHRoYXQgdGhlIGJ1ZmZl ciB3aWxsIGJlIG1hcHBlZCBpbmRlZmluaXRlbHkuCj4gKwkJICogVGhlIGJ1ZmZlciBpcyBwcmV0 dHkgdW5saWtlbHkgdG8gZ2V0IHVubWFwcGVkIGJ5IHRoZSB1c2VyCj4gKwkJICogYXQgdGhpcyBw b2ludC4KPiArCQkgKi8KPiArCQlpZiAoYm8tPmNwdV9tYXBfY291bnQgIT0gSU5UX01BWCkKPiAr CQkJYm8tPmNwdV9tYXBfY291bnQrKzsKPiArCj4gICAJCSpjcHUgPSBiby0+Y3B1X3B0cjsKPiAg IAkJcHRocmVhZF9tdXRleF91bmxvY2soJmJvLT5jcHVfYWNjZXNzX211dGV4KTsKPiAgIAkJcmV0 dXJuIDA7Cj4gICAJfQo+ICAgCj4gICAJYXNzZXJ0KGJvLT5jcHVfbWFwX2NvdW50ID09IDApOwo+ ICAgCj4gICAJbWVtc2V0KCZhcmdzLCAwLCBzaXplb2YoYXJncykpOwo+ICAgCj4gICAJLyogUXVl cnkgdGhlIGJ1ZmZlciBhZGRyZXNzIChhcmdzLmFkZHJfcHRyKS4KPiBAQCAtNDkyLDIxICs1MDEs MjcgQEAgZHJtX3B1YmxpYyBpbnQgYW1kZ3B1X2JvX2NwdV91bm1hcChhbWRncHVfYm9faGFuZGxl IGJvKQo+ICAgCj4gICAJcHRocmVhZF9tdXRleF9sb2NrKCZiby0+Y3B1X2FjY2Vzc19tdXRleCk7 Cj4gICAJYXNzZXJ0KGJvLT5jcHVfbWFwX2NvdW50ID49IDApOwo+ICAgCj4gICAJaWYgKGJvLT5j cHVfbWFwX2NvdW50ID09IDApIHsKPiAgIAkJLyogbm90IG1hcHBlZCAqLwo+ICAgCQlwdGhyZWFk X211dGV4X3VubG9jaygmYm8tPmNwdV9hY2Nlc3NfbXV0ZXgpOwo+ICAgCQlyZXR1cm4gLUVJTlZB TDsKPiAgIAl9Cj4gICAKPiAtCWJvLT5jcHVfbWFwX2NvdW50LS07Cj4gKwkvKiBJZiB0aGUgY291 bnRlciBoYXMgYWxyZWFkeSByZWFjaGVkIElOVF9NQVgsIGRvbid0IGRlY3JlbWVudCBpdC4KPiAr CSAqIFRoaXMgaXMgYmVjYXVzZSBhbWRncHVfYm9fY3B1X21hcCBkb2Vzbid0IGluY3JlbWVudCBp dCBwYXN0Cj4gKwkgKiBJTlRfTUFYLgo+ICsJICovCj4gKwlpZiAoYm8tPmNwdV9tYXBfY291bnQg IT0gSU5UX01BWCkKPiArCQliby0+Y3B1X21hcF9jb3VudC0tOwo+ICsKPiAgIAlpZiAoYm8tPmNw dV9tYXBfY291bnQgPiAwKSB7Cj4gICAJCS8qIG1hcHBlZCBtdWx0aXBsZSB0aW1lcyAqLwo+ICAg CQlwdGhyZWFkX211dGV4X3VubG9jaygmYm8tPmNwdV9hY2Nlc3NfbXV0ZXgpOwo+ICAgCQlyZXR1 cm4gMDsKPiAgIAl9Cj4gICAKPiAgIAlyID0gZHJtX211bm1hcChiby0+Y3B1X3B0ciwgYm8tPmFs bG9jX3NpemUpID09IDAgPyAwIDogLWVycm5vOwo+ICAgCWJvLT5jcHVfcHRyID0gTlVMTDsKPiAg IAlwdGhyZWFkX211dGV4X3VubG9jaygmYm8tPmNwdV9hY2Nlc3NfbXV0ZXgpOwo+ICAgCXJldHVy biByOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1k LWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==