From: "flichtenheld (Code Review)" Date: Mon, 13 Apr 2026 11:55:29 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <769415911ec44a3bfc9bbd24a5db746e2f6d382a-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="m5z/IYRvfmA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_mbedtls: Fix format string in get_ssl_library_version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --m5z/IYRvfmA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail to review the following change. Change subject: ssl_mbedtls: Fix format string in get_ssl_library_version ...................................................................... ssl_mbedtls: Fix format string in get_ssl_library_version These are unsigned values, so treat them as such. Identified by cppcheck. Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Signed-off-by: Frank Lichtenheld --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/1626/1 diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index a62ff76..85c771a 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1572,7 +1572,7 @@ { static char mbedtls_version[30]; unsigned int pv =3D mbedtls_version_get_number(); - snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d"= , (pv >> 24) & 0xff, + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u"= , (pv >> 24) & 0xff, (pv >> 16) & 0xff, (pv >> 8) & 0xff); return mbedtls_version; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86890a366f5967f Gerrit-Change-Number: 1626 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --m5z/IYRvfmA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

ssl_mbedtls: Fix format string in get_ssl_l=
ibrary_version

These are unsigned values, so treat them as such.
=
Identified by cppcheck.

Change-Id: I232fba91cfcca6c35d37696bc868= 90a366f5967f
Signed-off-by: Frank Lichtenheld <frank@...2641...>---
M src/openvpn/ssl_mbedtls.c
1 file changed, 1 insertion(+), 1 d= eletion(-)

git pull ssh://gerrit.openvpn.net:294=
18/openvpn refs/changes/26/1626/1
diff --git a/src/openvpn/ssl_mbed=
tls.c b/src/openvpn/ssl_mbedtls.c
index a62ff76..85c771a 10= 0644
--- a/src/openvpn/ssl_mbedtls.c
+++ b/= src/openvpn/ssl_mbedtls.c
@@ -1572,7 +1572,7 @@
<= span> {
static char mbedtls_version[30];
unsigned int pv =3D mbedtls_version_get_number();
- snprintf(mbedtls_version, sizeof(mb= edtls_version), "mbed TLS %d.%d.%d", (pv >> 24) & 0xff,=
+ snprintf(mbedtl= s_version, sizeof(mbedtls_version), "mbed TLS %u.%u.%u", (pv >= > 24) & 0xff,
(pv >> 16) & 0= xff, (pv >> 8) & 0xff);
return mbedtls_versi= on;
}

To view, visit <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/1626?usp=3Demail">change 16= 26. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I232fba91cfcca6c35d37696bc86= 890a366f5967f
Gerrit-Change-Number: 1626
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --m5z/IYRvfmA=--