Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA435C4338F for ; Mon, 16 Aug 2021 12:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B17EB61BFD for ; Mon, 16 Aug 2021 12:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232167AbhHPMVH (ORCPT ); Mon, 16 Aug 2021 08:21:07 -0400 Received: from mga17.intel.com ([192.55.52.151]:21097 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbhHPMVH (ORCPT ); Mon, 16 Aug 2021 08:21:07 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="196115267" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="196115267" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:20:35 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="530477991" Received: from gaoboxix-mobl1.ccr.corp.intel.com (HELO [10.254.215.86]) ([10.254.215.86]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:20:33 -0700 Cc: baolu.lu@linux.intel.com, Joerg Roedel , stable@vger.kernel.org, Saeed Mirzamohammadi , Ashok Raj , Camille Lu To: Greg Kroah-Hartman References: <20210816113932.1210581-1-baolu.lu@linux.intel.com> From: Lu Baolu Subject: Re: [PATCH 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width Message-ID: <76945715-9a4c-2f94-b458-b6ab53d40a1c@linux.intel.com> Date: Mon, 16 Aug 2021 20:20:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Greg, On 2021/8/16 19:48, Greg Kroah-Hartman wrote: > On Mon, Aug 16, 2021 at 07:39:32PM +0800, Lu Baolu wrote: >> From: Saeed Mirzamohammadi >> >> [ Upstream commit 327d5b2fee91c404a3956c324193892cf2cc9528 ] > > Also, this really does not look like this commit at all :( > This is not a back port. It's a fix for some stable kernels. Sorry for the confusion. The error happens in a helper function that has been deprecated in the upstream kernel by above commit. I added below explanation in the commit message: " This issue happens on the code path of getting a private domain for a device. A private domain was needed when the domain of an iommu group couldn't meet the requirement of a device. The IOMMU core has been evolved to eliminate the need for private domain, hence this code path has already been removed from the upstream since commit 327d5b2fee91c ("iommu/vt-d: Allow 32bit devices to uses DMA domain"). Instead of back porting all patches that are required for removing the private domain, this simply fixes it in the affected stable kernel between v4.16 and v5.7. " I'm sorry if this is not the right way to do this. Best regards, baolu