From: "cron2 (Code Review)" Date: Sat, 14 Mar 2026 17:16:12 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <76a6d8520ae057d5b113c2b63328aef317548fa3-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="52f17s3uRdo="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dns: Change arguments to setenv_dns_option to avoid sign-compare warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --52f17s3uRdo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1558?usp=3Demail ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: dns: Change arguments to setenv_dns_option to avoid sign-co= mpare warning ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: I withdraw my +2 for the time being, because I do not understand why this i= s needed in the first place - also, the *new* code brings `"dns_server_%zu_= resolve_domain_%d", i, j` which can't be right (second `%d`) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1558?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b1625dcb7e6fb5 Gerrit-Change-Number: 1558 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 14 Mar 2026 17:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --52f17s3uRdo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 3:Code-Review -1=

The change is no longer submittable: Code-Review is unsatisfied now.=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #3:

      I withdraw = my +2 for the time being, because I do not understand why this is needed in= the first place - also, the *new* code brings `"dns_server_%zu_resolv= e_domain_%d", i, j` which can't be right (second `%d`)

    To view, visit change 1558. To unsubscribe, or for help writing = mail filters, visit settings.

    =
    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b= 1625dcb7e6fb5
    Gerrit-Change-Number: 1558
    Gerrit-PatchSet: 3
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Sat, 14 Mar 2026 17:16:12= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    = --52f17s3uRdo=--