From: "plaisthos (Code Review)" Date: Mon, 11 Dec 2023 14:03:21 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <76acb9582ef76adec7cef23df22a8c1ce2e60259-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0iyLFeGXwUY="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --0iyLFeGXwUY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/465?usp=3Demail ) Change subject: Make it more explicit and visible when pkg-config is not fo= und ...................................................................... Patch Set 1: (1 comment) File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/465/comment/1f49058a_883de55c : PS1, Line 387: pkg_config_found=3D"(not found)" > indent Damn indenting with tabs instead of spaces. I will double check all other i= ndents as well. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a Gerrit-Change-Number: 465 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 11 Dec 2023 14:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --0iyLFeGXwUY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File configure.ac:

    • Patch Set #1, Line 387: pkg_config_found=3D"(not foun= d)"

      indent

      Damn indenting with tabs instead of s= paces. I will double check all other indents as well.

    To view, visit change 465. To unsubscribe, or for help writing mail filters= , visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229c= bfc08a3d8854a
    Gerrit-Change-Number: 465
    Gerrit-PatchSet: 1
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Mon, 11 Dec 2023 14:03:21= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --0iyLFeGXwUY=--