Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67CC7C433EF for ; Thu, 16 Dec 2021 17:57:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.248170.428053 (Exim 4.92) (envelope-from ) id 1mxv0m-0004Do-7G; Thu, 16 Dec 2021 17:57:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 248170.428053; Thu, 16 Dec 2021 17:57:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxv0m-0004Dh-4Q; Thu, 16 Dec 2021 17:57:48 +0000 Received: by outflank-mailman (input) for mailman id 248170; Thu, 16 Dec 2021 17:57:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mxv0k-0004DD-FJ for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:57:46 +0000 Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac118028-5e99-11ec-9e60-abaf8a552007; Thu, 16 Dec 2021 18:57:45 +0100 (CET) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47120) by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1mxv0h-000Exx-oW (Exim 4.95) (return-path ); Thu, 16 Dec 2021 17:57:43 +0000 Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 635661FAC8; Thu, 16 Dec 2021 17:57:43 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac118028-5e99-11ec-9e60-abaf8a552007 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <76b1346c-b42b-46d7-943d-01019e95b60c@srcf.net> Date: Thu, 16 Dec 2021 17:57:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [XEN PATCH 25/57] tools/examples: cleanup Makefile Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Anthony PERARD , Ian Jackson , Wei Liu References: <20211206170241.13165-1-anthony.perard@citrix.com> <20211206170241.13165-26-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20211206170241.13165-26-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/12/2021 17:02, Anthony PERARD wrote: > diff --git a/tools/examples/Makefile b/tools/examples/Makefile > index 14e24f4cb3..48b520e133 100644 > --- a/tools/examples/Makefile > +++ b/tools/examples/Makefile > @@ -26,10 +22,8 @@ uninstall: uninstall-readmes uninstall-configs > > .PHONY: install-readmes > install-readmes: > - [ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \ > - $(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR) > - set -e; for i in $(XEN_READMES); \ > - do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \ > + $(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR) > + set -e; for i in $(XEN_READMES); do \ > $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \ Hmm.  Do we need a shell loop here at all?  Can't $(INSTALL_DATA) take multiple $i's at the same time? ~Andrew