From: "flichtenheld (Code Review)" Date: Fri, 8 Dec 2023 16:40:22 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="txItmy8Nogo="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --txItmy8Nogo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/471?usp=3Demail ) Change subject: Add test_ssl unit test and test export of PEM to file ...................................................................... Patch Set 1: Code-Review-1 (6 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/471/comment/7cbe21a6_5ded543e : PS1, Line 560: "test_ssl" Those are sorted alphabetically http://gerrit.openvpn.net/c/openvpn/+/471/comment/fb6707f8_9e4c3991 : PS1, Line 675: target_sources(test_ssl PRIVATE also sorted alphabetically File tests/unit_tests/openvpn/mock_management.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/013fb9b0_9685277c : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. Copy & paste error? Or intentional? File tests/unit_tests/openvpn/mock_ssl_dependencies.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/e183659b_a49b0182 : PS1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. intentional? http://gerrit.openvpn.net/c/openvpn/+/471/comment/8366d424_83a92832 : PS1, Line 24: /* Minimal set of mocked management function/globals to get u= nit tests to "management" is probably copy&paste File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/471/comment/c8cca67b_59a239d1 : PS1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. probably not intentional -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381 Gerrit-Change-Number: 471 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 08 Dec 2023 16:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --txItmy8Nogo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

6 comments:

  • File CMakeLists.txt:

  • File tests/unit_tests/openvpn/mock_management.c:

    • Patch Set #1, Line 8: * Copyright (C) 2017-2021 Fox Cryp= to B.V. <openvpn@...2507...>

      Copy & paste error? Or intentional?

  • File tests/unit_tests/o= penvpn/mock_ssl_dependencies.c:

    • Patch Set #1, Line 8: * Copyright (C) 2017-2021 Fox Crypto B.V. <openvpn@...2754...= ...>

      Patch Set #1, Line 24: /* Minimal set of mocked management functio= n/globals to get unit tests to

      "management" is probably copy&paste<= /p>

  • File tests/unit_t= ests/openvpn/test_ssl.c:

      Patch Set #1, Line 8: * Copyright (C) 2016-2021 Fox Crypto B.V. <openvpn@...2507...>=

      proba= bly not intentional

To view, visit change 471. To unsu= bscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c= 77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Fri, 08 Dec 2023 16:40:22= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--txItmy8Nogo=--