References: <38693ff6-f6d2-33a3-889c-96ee85ddb86c@...1856...> <20200213104551.25165-1-arne@...1227...> From: Arne Schwabe Message-ID: <76c2096d-793c-919a-cd18-386915c73d46@...1227...> Date: Mon, 17 Feb 2020 11:03:57 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: de-DE Subject: Re: [Openvpn-devel] [PATCH v2 1/4] Only announce IV_NCP=2 when we are willing to support these ciphers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Lev Stipakov Cc: openvpn-devel Am 17.02.20 um 10:58 schrieb Lev Stipakov: > Hi, > > Since --ncp-ciphers are non-negotiable, why do we need > to store it in context_1 at all? Cannot we use the value > from struct options? The push context do not have access to the options struct. Using options directly would be massive refactoring. I want to avoid that for this small patch. Arne