Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F47BC54FD0 for ; Thu, 23 Apr 2020 18:50:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D6820704 for ; Thu, 23 Apr 2020 18:50:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="DsgbpK2p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D6820704 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRguh-0004oz-9B; Thu, 23 Apr 2020 18:49:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRgug-0004ou-9s for xen-devel@lists.xenproject.org; Thu, 23 Apr 2020 18:49:30 +0000 X-Inumbo-ID: 28c4a1b3-8593-11ea-93f5-12813bfff9fa Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 28c4a1b3-8593-11ea-93f5-12813bfff9fa; Thu, 23 Apr 2020 18:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1587667768; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=kk5X5yCTAXbomXGohlK0iF7kF+m+7o5Mk6x6xfWmjXk=; b=DsgbpK2pCsgR8wnkdgFT8iSG07oDVow4gGN8HXCAwCOzADXrTM1/sUXQ vxWip3OuuA1ZDnR6wY1/qK6nNYwo6MlAgYXtc6LtYdpNdqpEjfNkFjOSP 3jtOt0VIOJvR1cqHeXJzbVXOqJ8W3EbAiCpU6QPwV6baBQRPnN5ghpI6E 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: VfkqWQa4mK5hwnHpwUYKZ9m2V1rQyzHWF3XMO5LpZS8R40/GN4bu21d32urIPGLrbpMrVvgclZ NEzLkzg07utyMySx3YTkjBYp/MS+989Lzx61CXAzO5xXk0FcHVFGum6kDvuKEGtN4V7/p1uwE7 SXwxpC4UrEd2PEsosZaobcnAA0r7xKEn0GrWAJcr53HWEdbfhFuFwFua4O1xQX9pXKOYJjx60G 8K/uV8v1soaxQjyGf+gVqOj4OXCJaoz7hpraSCrcOSJfiQC5lHFWoXrc40OgiQ0HfBKVBPDNNX rHk= X-SBRS: 2.7 X-MesageID: 16836228 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,307,1583211600"; d="scan'208";a="16836228" Subject: Re: [PATCH 3/3] x86/pv: Don't use IST for NMI/#MC/#DB in !CONFIG_PV builds To: Jan Beulich References: <20200420145911.5708-1-andrew.cooper3@citrix.com> <20200420145911.5708-4-andrew.cooper3@citrix.com> <08a798db-3126-7ccd-17f3-476607cc9e45@suse.com> From: Andrew Cooper Message-ID: <76fa899a-2b35-8ea9-159e-c9e3dcf88f53@citrix.com> Date: Thu, 23 Apr 2020 19:49:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <08a798db-3126-7ccd-17f3-476607cc9e45@suse.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21/04/2020 08:48, Jan Beulich wrote: > On 20.04.2020 16:59, Andrew Cooper wrote: >> --- a/xen/include/asm-x86/processor.h >> +++ b/xen/include/asm-x86/processor.h >> @@ -441,12 +441,18 @@ struct tss_page { >> }; >> DECLARE_PER_CPU(struct tss_page, tss_page); >> >> +/* >> + * Interrupt Stack Tables. Used to force a stack switch on a CPL0=>0 >> + * interrupt/exception. #DF uses IST all the time to detect stack overflows >> + * cleanly. NMI/#MC/#DB only need IST to cover the SYSCALL gap, and therefore >> + * only necessary with PV guests. >> + */ > Is it really only the SYSCALL gap that we mean to cover? In particular > for #MC I'd suspect it is a good idea to switch stacks as well, to get > onto a distinct memory page in case the #MC was stack related. If #MC occurs on your stack, you have already lost.  The chances of only taking a single #MC are tiny because the next-line prefetcher will be doing its job (or it hits when the lines (plural) leave L3, which will be in guest context at some point in the future.) The very best you can hope for is to cleanly print something and crash - even if you manage to run the handler, you've got no idea if the interrupted context had a spinlock held, and Xen has no support for changing to a different pcpu stack. > With NMI it might as well be better to switch; Why?  There is no benefit (with no SYSCALL in the picture), and a downside which causes state loss. > I agree we don't need any > switching for #DB. > > I also think that the comment at the top of current.h would want > updating with these adjustments (which I notice lacks the #DB part > anyway). Oops - I totally forgot that for the XSA-260 fix. ~Andrew