From: "cron2 (Code Review)" Date: Sun, 5 Apr 2026 10:23:36 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <770d2f72c152c72a8ed8f42ca920aca4361311d4-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="vsL/P1zsBhQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove various unused structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --vsL/P1zsBhQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 07?usp=3Demail ) Change subject: Remove various unused structs ...................................................................... Remove various unused structs Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1607 Message-Id: <20260404203615.30863-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 468.html Signed-off-by: Gert Doering --- M src/openvpn/mtcp.c M src/openvpn/multi_io.c M src/openvpn/networking_sitnl.c M src/openvpn/route.c 4 files changed, 0 insertions(+), 31 deletions(-) diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index b7bef46..2eab7b7 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -37,14 +37,6 @@ #include #endif -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - struct multi_instance * multi_create_instance_tcp(struct multi_context *m, struct link_socket *soc= k) { diff --git a/src/openvpn/multi_io.c b/src/openvpn/multi_io.c index f484fe2..e6f4e9c 100644 --- a/src/openvpn/multi_io.c +++ b/src/openvpn/multi_io.c @@ -46,14 +46,6 @@ #define MULTI_IO_FILE_CLOSE_WRITE ((void *)5) #define MULTI_IO_DCO ((void *)6) -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - #ifdef ENABLE_DEBUG static const char * pract(int action) diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c index b88f03c..baf6f89 100644 --- a/src/openvpn/networking_sitnl.c +++ b/src/openvpn/networking_sitnl.c @@ -124,15 +124,6 @@ typedef int (*sitnl_parse_reply_cb)(struct nlmsghdr *msg, void *arg); /** - * Object returned by route request operation - */ -struct sitnl_route_data_cb -{ - unsigned int iface; - inet_address_t gw; -}; - -/** * Helper function used to easily add attributes to a rtnl message */ static int diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 1cfbf80..3b18f74 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3257,12 +3257,6 @@ * netlink(3), netlink(7), rtnetlink(7) * https://www.virtualbox.org/svn/vbox/trunk/src/VBox/NetworkServices/NAT/ */ -struct rtreq -{ - struct nlmsghdr nh; - struct rtmsg rtm; - char attrbuf[512]; -}; void get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6, const struc= t in6_addr *dest, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1607?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Gerrit-Change-Number: 1607 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --vsL/P1zsBhQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

Remove various unused structs

Change-Id: = I46499ff1f40dbdb94b84d58d17457d0ccdd75288
Signed-off-by: Frank Lichtenhe= ld <frank@...2641...>
Acked-by: Gert Doering <gert@...1296...&g= t;
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1607
Message-Id= : <20260404203615.30863-1-gert@...1296...>
URL: https://www.mail-a= rchive.com/openvpn-devel@lists.sourceforge.net/msg36468.html
Signed-off-= by: Gert Doering <gert@...1296...>
---
M src/openvpn/mtcp.c
= M src/openvpn/multi_io.c
M src/openvpn/networking_sitnl.c
M src/openv= pn/route.c
4 files changed, 0 insertions(+), 31 deletions(-)

diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c
ind= ex b7bef46..2eab7b7 100644
--- a/src/openvpn/mtcp.c<= br>+++ b/src/openvpn/mtcp.c
@@ -37,14 +37,6 @@=
#include <sys/inotify.h>
#endif
-struct ta_iow= _flags
-{
- unsigned int flags;
<= span style=3D"color: hsl(0, 100%, 40%);">- unsigned int ret;
<= span style=3D"color: hsl(0, 100%, 40%);">- unsigned int tun;
<= span style=3D"color: hsl(0, 100%, 40%);">- unsigned int sock;
= -};
-
struct multi_instance * multi_create_instance_tcp(struct multi_context *m, struct link_sock= et *sock)
{
diff --git a/src/openvpn/multi= _io.c b/src/openvpn/multi_io.c
index f484fe2..e6f4e9c 10064= 4
--- a/src/openvpn/multi_io.c
+++ b/src/op= envpn/multi_io.c
@@ -46,14 +46,6 @@
#defin= e MULTI_IO_FILE_CLOSE_WRITE ((void *)5)
#define MULTI_IO_D= CO ((void *)6)

-struct ta_iow_flags
-{
- unsigned int flags;
- unsigned int ret;
- unsigned int tun;
- unsigned int sock;
-};
-
#ifdef ENABLE_DEBUG
static const char *
pract(int action)
diff --git a/src/openvpn/networking_si= tnl.c b/src/openvpn/networking_sitnl.c
index b88f03c..baf6f= 89 100644
--- a/src/openvpn/networking_sitnl.c
+++ b/src/openvpn/networking_sitnl.c
@@ -124,15 +124,6 = @@
typedef int (*sitnl_parse_reply_cb)(struct nlmsghdr *ms= g, void *arg);

/**
- * Object returned by route request operati= on
- */
-struct sitnl_route_data_cb
= -{
- unsigned int iface;
- inet_address_t gw;
-};
-
-/**
= * Helper function used to easily add attributes to a rtnl message
*/
static int
diff --git = a/src/openvpn/route.c b/src/openvpn/route.c
index 1cfbf80..= 3b18f74 100644
--- a/src/openvpn/route.c
++= + b/src/openvpn/route.c
@@ -3257,12 +3257,6 @@
* netlink(3), netlink(7), rtnetlink(7)

* https://ww= w.virtualbox.org/svn/vbox/trunk/src/VBox/NetworkServices/NAT/
*/
-struct rtreq
-{
- struct nlmsghdr nh;
- struct rtmsg rtm;
- char attrbuf[512];
-};

vo= id
get_default_gateway_ipv6(struct route_ipv6_gateway_info= *rgi6, const struct in6_addr *dest,

To= view, visit change 1607. To unsubscribe, or for help writing mail filters, vis= it settings.=

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I46499ff1f40dbdb94b84d58d174= 57d0ccdd75288
Gerrit-Change-Number: 1607
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --vsL/P1zsBhQ=--