From: "ordex (Code Review)"
Date: Wed, 8 Jan 2025 15:21:08 +0000
In-Reply-To:
References:
Reply-To: a@...2181..., arne-openvpn@...1227..., gianmarco@...2726...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296...
Message-ID: <772f6f7a19f8961d16c32f204f41d57dc6438762-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Dn0cE61oVYc="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to
specify 'local' multiple times in config files
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: cron2 , flichtenheld , plaisthos , openvpn-devel
--Dn0cE61oVYc=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, its_Giaan, plais=
thos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/436?usp=3Demail )
Change subject: allow user to specify 'local' multiple times in config files
......................................................................
Patch Set 10:
(1 comment)
File src/openvpn/options.h:
http://gerrit.openvpn.net/c/openvpn/+/436/comment/6b965d3f_513428fb :
PS10, Line 105: struct local_list *local_list;
> I do not like this data structure - having an extra indirection seems to =
serve no good purpose (like [=E2=80=A6]
Gianmarco dived north and south to remove this local_list container. Howeve=
r, he found the actual reason for having a pointer to a container here, ins=
tead of the plain array: the value of `struct local_list *` is copied over =
all connection entries, so that the list of locals can be shared.
If we remove such container and let a `struct connection_entry` directly ha=
ve a `local_list[]` member, we then need to copy this array over to every o=
ther connection entry.
Hence, we use more memory and we must memcpy() the array to every `ce`.
Would you agree that it may be better to keep the local_list container as i=
t is now and avoid this complexity?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 10
Gerrit-Owner: ordex
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: its_Giaan
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 08 Jan 2025 15:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--Dn0cE61oVYc=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
I do not like this data structure - having =
an extra indirection seems to serve no good purpose (like [=E2=80=A6]
Gianm=
arco dived north and south to remove this local_list container. However, he=
found the actual reason for having a pointer to a container here, instead =
of the plain array: the value of `struct local_list *` is copied over all c=
onnection entries, so that the list of locals can be shared.
If we remove such container=
and let a `struct connection_entry` directly have a `local_list[]` member,=
we then need to copy this array over to every other connection entry.
<=
p style=3D"white-space: pre-wrap; word-wrap: break-word;">Hence, we use mor=
e memory and we must memcpy() the array to every `ce`.
Would you agree that it may be be=
tter to keep the local_list container as it is now and avoid this complexit=
y?
To view, visit change 436. To unsubscribe, or for h=
elp writing mail filters, visit settings.