From: Tvrtko Ursulin Subject: Re: [PATCH 6/8] drm/i915: Add global barrier support Date: Tue, 14 Aug 2018 15:59:48 +0100 Message-ID: <77575645-9269-d84a-6159-8d44e06feed1@linux.intel.com> References: <20180814144058.19286-1-tvrtko.ursulin@linux.intel.com> <20180814144058.19286-7-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF3456E27E for ; Tue, 14 Aug 2018 14:59:53 +0000 (UTC) In-Reply-To: <20180814144058.19286-7-tvrtko.ursulin@linux.intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org, Chris Wilson List-Id: intel-gfx@lists.freedesktop.org CkNocmlzLCBmb3IgdGhpcyBvbmUgcGxlYXNlIGxldCBtZSBrbm93IGlmIGl0IGlzIG9rYXkgdG8g Z2l2ZSB5b3UgCmF1dGhvcnNoaXAgYW5kIHRvIGFkZCB5b3VyIFMtby1CLgoKVHZydGtvCgpPbiAx NC8wOC8yMDE4IDE1OjQwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPiBGcm9tOiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IAo+IEdsb2JhbCBiYXJyaWVyIGlzIGEg ZmFjaWxpdHkgdG8gYWxsb3cgc2VyaWFsaXphdGlvbiBiZXR3ZWVuIGRpZmZlcmVudAo+IHRpbWVs aW5lcy4KPiAKPiBBZnRlciBjYWxsaW5nIGk5MTVfZ2VtX3NldF9nbG9iYWxfYmFycmllciBvbiBh IHJlcXVlc3QsIGFsbCBmb2xsb3dpbmcKPiBzdWJtaXNzaW9ucyBvbiBhbnkgZW5naW5lIHdpbGwg YmUgc2V0IHVwIGFzIGRlcGVuZGluZyBvbiB0aGlzIGdsb2JhbAo+IGJhcnJpZXIuIE9uY2UgdGhl IGdsb2JhbCBiYXJyaWVyIGhhcyBiZWVuIGNvbXBsZXRlZCBpdCBhdXRvbWF0aWNhbGx5IGdldHMK PiBjbGVhcmVkIGFuZCB0aGluZ3MgY29udGludWUgYXMgbm9ybWFsLgo+IAo+IFRoaXMgZmFjaWxp dHkgd2lsbCBiZSB1c2VkIGJ5IHRoZSB1cGNvbWluZyBjb250ZXh0IFNTRVUgY29kZS4KPiAKPiAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gVGhpcyBjb2RlIHdhcyBwYXJ0IG9mIHRoZSBsYXJnZXIgU1NFVSBw YXRjaCBidXQgSSBleHRyYWN0ZWQgaXQgdG8gYmUKPiBzZXBhcmF0ZSBmb3IgZWFzZSBvZiByZXZp ZXcgYW5kIGNsYXJpdHkuIEkgdGhpbmsgaXQgb3JpZ2luYXRlcyBmcm9tIENocmlzCj4gV2lsc29u IHNvIHBlcm1pc3Npb24gcGVuZGluZyBJIHdpbGwgY2hhbmdlIHRoZSBhdXRob3IgYW5kIGFkZCBh cHByb3ByaWF0ZQo+IFMtby1CLgo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmggICAgIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICB8ICAyICsrCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYyB8IDE2ICsrKysrKysrKysrKysrKysKPiAgIDMg ZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+IGluZGV4IDVjMTJkMjY3NjQzNS4uNjQzMDg5YmEwMWI5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTIwOTgsNiArMjA5OCwxNiBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSB7Cj4gICAJCXUzMiBhY3RpdmVfcmVxdWVzdHM7Cj4gICAJCXUzMiByZXF1ZXN0X3NlcmlhbDsK PiAgIAo+ICsJCS8qKgo+ICsJCSAqIEdsb2JhbCBiYXJyaWVyIGZvciB0aGUgYWJpbGl0eSB0byBz ZXJpYWxpemUgb3JkZXJpbmcgYmV0d2Vlbgo+ICsJCSAqIGRpZmZlcmVudCB0aW1lbGluZXMuCj4g KwkJICoKPiArCQkgKiBVc2VycyBjYW4gY2FsbCBpOTE1X2dlbV9zZXRfZ2xvYmFsX2JhcnJpZXIg d2hpY2ggd2lsbCBtYWtlCj4gKwkJICogYWxsIHN1YnNlcXVlbnQgc3VibWlzc2lvbiBiZSBleGVj dXRlIG9ubHkgYWZ0ZXIgdGhpcyBiYXJyaWVyCj4gKwkJICogaGFzIGJlZW4gY29tcGxldGVkLgo+ ICsJCSAqLwo+ICsJCXN0cnVjdCBpOTE1X2dlbV9hY3RpdmUgZ2xvYmFsX2JhcnJpZXI7Cj4gKwo+ ICAgCQkvKioKPiAgIAkJICogSXMgdGhlIEdQVSBjdXJyZW50bHkgY29uc2lkZXJlZCBpZGxlLCBv ciBidXN5IGV4ZWN1dGluZwo+ICAgCQkgKiB1c2Vyc3BhY2UgcmVxdWVzdHM/IFdoaWxzdCBpZGxl LCB3ZSBhbGxvdyBydW50aW1lIHBvd2VyCj4gQEAgLTMyMzAsNiArMzI0MCwyMyBAQCBpOTE1X3Zt X3RvX3BwZ3R0KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtKQo+ICAgCXJldHVybiBjb250 YWluZXJfb2Yodm0sIHN0cnVjdCBpOTE1X2h3X3BwZ3R0LCB2bSk7Cj4gICB9Cj4gICAKPiArLyoq Cj4gKyAqIGk5MTVfZ2VtX3NldF9nbG9iYWxfYmFycmllciAtIG9yZGVycyBzdWJtaXNzaW9uIG9u IGRpZmZlcmVudCB0aW1lbGluZXMKPiArICogQGk5MTU6IGk5MTUgZGV2aWNlIHByaXZhdGUKPiAr ICogQHJxOiByZXF1ZXN0IGFmdGVyIHdoaWNoIG5ldyBzdWJtaXNzaW9ucyBjYW4gcHJvY2VlZAo+ ICsgKgo+ICsgKiBTZXRzIHRoZSBwYXNzZWQgaW4gcmVxdWVzdCBhcyB0aGUgc2VyaWFsaXphdGlv biBwb2ludCBmb3IgYWxsIHN1YnNlcXVlbnQKPiArICogc3VibWlzc2lvbnMsIHJlZ2FyZGxlc3Mg b2YgdGhlIGVuZ2luZS90aW1lbGluZS4gU3Vic2VxdWVudCByZXF1ZXN0cyB3aWxsIG5vdAo+ICsg KiBiZSBzdWJtaXR0ZWQgdG8gR1BVIHVudGlsIHRoZSBnbG9iYWwgYmFycmllciBoYXMgYmVlbiBj b21wbGV0ZWQuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHZvaWQKPiAraTkxNV9nZW1fc2V0X2ds b2JhbF9iYXJyaWVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICsJCQkgICAgc3Ry dWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gK3sKPiArCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmk5MTUt PmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICsJaTkxNV9nZW1fYWN0aXZlX3NldCgmaTkxNS0+Z3QuZ2xv YmFsX2JhcnJpZXIsIHJxKTsKPiArfQo+ICsKPiAgIC8qIGk5MTVfZ2VtX2ZlbmNlX3JlZy5jICov Cj4gICBzdHJ1Y3QgZHJtX2k5MTVfZmVuY2VfcmVnICoKPiAgIGk5MTVfcmVzZXJ2ZV9mZW5jZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u Ywo+IGluZGV4IDA0NTNlYjQyYTFhMy4uYmU0NjJlZjY1Nzg2IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jCj4gQEAgLTU3NTIsNiArNTc1Miw4IEBAIGludCBpOTE1X2dlbV9pbml0X2Vhcmx5 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlpZiAoIWRldl9wcml2LT5w cmlvcml0aWVzKQo+ICAgCQlnb3RvIGVycl9kZXBlbmRlbmNpZXM7Cj4gICAKPiArCWluaXRfcmVx dWVzdF9hY3RpdmUoJmRldl9wcml2LT5ndC5nbG9iYWxfYmFycmllciwgTlVMTCk7Cj4gKwo+ICAg CUlOSVRfTElTVF9IRUFEKCZkZXZfcHJpdi0+Z3QudGltZWxpbmVzKTsKPiAgIAlJTklUX0xJU1Rf SEVBRCgmZGV2X3ByaXYtPmd0LmFjdGl2ZV9yaW5ncyk7Cj4gICAJSU5JVF9MSVNUX0hFQUQoJmRl dl9wcml2LT5ndC5jbG9zZWRfdm1hKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+ IGluZGV4IDA5ZWQ0ODgzM2I1NC4uOGI0NWY3NGRjNzQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9yZXF1ZXN0LmMKPiBAQCAtNjQ0LDYgKzY0NCwxOCBAQCBzdWJtaXRfbm90aWZ5KHN0cnVj dCBpOTE1X3N3X2ZlbmNlICpmZW5jZSwgZW51bSBpOTE1X3N3X2ZlbmNlX25vdGlmeSBzdGF0ZSkK PiAgIAlyZXR1cm4gTk9USUZZX0RPTkU7Cj4gICB9Cj4gICAKPiArc3RhdGljIGludCBhZGRfZ2xv YmFsX2JhcnJpZXIoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gK3sKPiArCXN0cnVjdCBpOTE1 X3JlcXVlc3QgKmJhcnJpZXI7Cj4gKwo+ICsJYmFycmllciA9IGk5MTVfZ2VtX2FjdGl2ZV9yYXco JnJxLT5pOTE1LT5ndC5nbG9iYWxfYmFycmllciwKPiArCQkJCSAgICAgICZycS0+aTkxNS0+ZHJt LnN0cnVjdF9tdXRleCk7Cj4gKwlpZiAoYmFycmllcikKPiArCQlyZXR1cm4gaTkxNV9yZXF1ZXN0 X2F3YWl0X2RtYV9mZW5jZShycSwgJmJhcnJpZXItPmZlbmNlKTsKPiArCj4gKwlyZXR1cm4gMDsK PiArfQo+ICsKPiAgIC8qKgo+ICAgICogaTkxNV9yZXF1ZXN0X2FsbG9jIC0gYWxsb2NhdGUgYSBy ZXF1ZXN0IHN0cnVjdHVyZQo+ICAgICoKPiBAQCAtODA2LDYgKzgxOCwxMCBAQCBpOTE1X3JlcXVl c3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBzdHJ1Y3QgaTkxNV9nZW1f Y29udGV4dCAqY3R4KQo+ICAgCSAqLwo+ICAgCXJxLT5oZWFkID0gcnEtPnJpbmctPmVtaXQ7Cj4g ICAKPiArCXJldCA9IGFkZF9nbG9iYWxfYmFycmllcihycSk7Cj4gKwlpZiAocmV0KQo+ICsJCWdv dG8gZXJyX3Vud2luZDsKPiArCj4gICAJLyogVW5jb25kaXRpb25hbGx5IGludmFsaWRhdGUgR1BV IGNhY2hlcyBhbmQgVExCcy4gKi8KPiAgIAlyZXQgPSBlbmdpbmUtPmVtaXRfZmx1c2gocnEsIEVN SVRfSU5WQUxJREFURSk7Cj4gICAJaWYgKHJldCkKPiAKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==