From: "mrbff (Code Review)"
Date: Wed, 23 Jul 2025 17:11:24 +0000
In-Reply-To:
References:
Reply-To: marco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277..., gert@...1296...
Message-ID: <77d9f65e3e7bf98a92f47d99432a68193fd17cf0-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="LQ9TTG2yatA="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow
OpenVPN in client mode to receive and handle PUSH ...
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , stipa , plaisthos , openvpn-devel
--LQ9TTG2yatA=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/808?usp=3Demail )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha=
ndle PUSH UPDATE control messages to allow options updating at runtime.
......................................................................
Patch Set 21:
(8 comments)
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/0bc4e799_eafa8770 :
PS19, Line 5567: apply_push_options(struct options *options,
> please do not move that one around in options. [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/010661f3_5e3b560e :
PS19, Line 5654:
> so I would call check_push_update_option_flags() from here, possibly movi=
ng the "while isspace(*line [=E2=80=A6]
Done
File src/openvpn/options_util.c:
http://gerrit.openvpn.net/c/openvpn/+/808/comment/47b8a262_12fab17a :
PS19, Line 198: if (!line || !*line || !**line)
> the use of a double pointer irritates me, because we never move the point=
er, instead `memmove()` the [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/8e312009_6f3eacc1 :
PS19, Line 231:
> If there is whitespace here (`? route`) we'll fail with `pushed option i=
s not updateable: ' route' [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/a777b4e8_51887b18 :
PS19, Line 252: msg(D_PUSH, "Pushed option is not updatable: '%=
s'", *line);
> Maybe add an " Ignoring. [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/b521c226_07b2309a :
PS19, Line 270: if (!o->pull_filter_list && !(is_update))
> So, if we call `check_push_update_option_flags()` from outside, we do not=
need this extra dance, che [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/4d43cf7c_4985502d :
PS19, Line 276: while (isspace(*line))
> It makes sense to move that upwards to `apply_push_options()`, before cal=
ling anything on the line. [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/808/comment/a7cb08ef_9c354e3e :
PS19, Line 310: return true;
> This duplication of the messages and `return true` looks a bit silly :-) =
- I would suggest to do [=E2=80=A6]
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 21
Gerrit-Owner: mrbff
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--LQ9TTG2yatA=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, stipa.
View C=
hange
8 comments:
Done
Patch Set #19, Line 5654:<=
/a>
=
so I would call check_push_update_option_flags() from here, possibly moving=
the "while isspace(*line [=E2=80=A6]
Done
File src/openvpn/options_util.c:
Patch Set #19, Line 198: <=
code style=3D"font-family:monospace,monospace"> if (!line || !*line || !=
**line)
the use of a double pointer irritates me, bec=
ause we never move the pointer, instead `memmove()` the [=E2=80=A6]Done
Patch Set #19, Line 231:
If there is whitespace here (`? ro=
ute`) we'll fail with `pushed option is not updateable: ' route=
9; [=E2=80=A6]
Done
- <=
p style=3D"margin-bottom: 4px;">Patch Set #19, Line 252:
msg(D_PUSH, "Pushed=
option is not updatable: '%s'", *line);Maybe add an " Ignoring. [=E2=80=A6]
Done
Patch Set =
#19, Line 270: if (=
!o->pull_filter_list && !(is_update))
So, =
if we call `check_push_update_option_flags()` from outside, we do not need =
this extra dance, che [=E2=80=A6]
Done
Patch Set #19, Line=
276: while (isspac=
e(*line))
It makes sense to move that upwards to `app=
ly_push_options()`, before calling anything on the line. [=E2=80=A6]Done=
p>
Patch Set #19, Line 310: return true;
This d=
uplication of the messages and `return true` looks a bit silly :-) - I woul=
d suggest to do [=E2=80=A6]
Acknowledged
To view,=
visit ch=
ange 808. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595=
c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 21
Gerrit-Owner: mrbff <marco@...2726...> <=
/div>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:24=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--LQ9TTG2yatA=--