Content-Type: multipart/mixed; boundary="===============0119017765794348036==" MIME-Version: 1.0 From: Tom Zanussi To: kbuild-all@lists.01.org Subject: [PATCH] tracing: Fix strncpy warning in trace_events_synth.c Date: Thu, 10 Mar 2022 11:17:07 -0600 Message-ID: <77deca8cbfd226981b3f1eab203967381e9b5bd9.camel@kernel.org> List-Id: --===============0119017765794348036== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable 0-day reported the strncpy error below: ../kernel/trace/trace_events_synth.c: In function 'last_cmd_set': ../kernel/trace/trace_events_synth.c:65:9: warning: 'strncpy' specified bou= nd depends on the length o\ f the source argument [-Wstringop-truncation] 65 | strncpy(last_cmd, str, strlen(str) + 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../kernel/trace/trace_events_synth.c:65:32: note: length computed here 65 | strncpy(last_cmd, str, strlen(str) + 1); | ^~~~~~~~~~~ There's no reason to use strncpy here, in fact there's no reason to do anything but a simple kstrdup() (note we don't even need to check for failure since last_cmod is expected to be either the last cmd string or NULL, and the containing function is a void return). Fixes: 27c888da9867 ("tracing: Remove size restriction on synthetic event c= md error logging") Reported-by: kernel test robot Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_synth.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_= synth.c index fdd79e07e2fc..5e8c07aef071 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -58,11 +58,8 @@ static void last_cmd_set(const char *str) return; = kfree(last_cmd); - last_cmd =3D kzalloc(strlen(str) + 1, GFP_KERNEL); - if (!last_cmd) - return; = - strncpy(last_cmd, str, strlen(str) + 1); + last_cmd =3D kstrdup(str, GFP_KERNEL); } = static void synth_err(u8 err_type, u16 err_pos) -- = 2.17.1 --===============0119017765794348036==--