From: Stefan Roese Date: Fri, 20 Sep 2019 11:11:29 +0200 Subject: [U-Boot] [PATCH 2/6] spl: spi: introduce spl_spi_get_uboot_raw_sector In-Reply-To: <20190920034412.31767-2-peng.fan@nxp.com> References: <20190920034412.31767-1-peng.fan@nxp.com> <20190920034412.31767-2-peng.fan@nxp.com> Message-ID: <77ec1985-e30b-facf-aa62-727b5428a38e@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peng, On 20.09.19 05:27, Peng Fan wrote: > Introduce a weak function spl_spi_get_uboot_raw_sector, then > platform could have their own implementation. > > Signed-off-by: Peng Fan > Cc: Simon Goldschmidt > Cc: Tien Fong Chee > Cc: Marek Vasut > Cc: Andreas Dannenberg > Cc: Alex Kiernan > Cc: Stefan Roese > Cc: Patrick Delaunay > Cc: Miquel Raynal > Cc: Michal Simek > --- > common/spl/spl_spi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/common/spl/spl_spi.c b/common/spl/spl_spi.c > index 9b74473377..1ba0e497d2 100644 > --- a/common/spl/spl_spi.c > +++ b/common/spl/spl_spi.c > @@ -62,6 +62,12 @@ static ulong spl_spi_fit_read(struct spl_load_info *load, ulong sector, > else > return 0; > } > + > +unsigned int __weak spl_spi_get_uboot_raw_sector(struct spi_flash *flash) > +{ > + return CONFIG_SYS_SPI_U_BOOT_OFFS; > +} > + > /* > * The main entry for SPI booting. It's necessary that SDRAM is already > * configured and available since this code loads the main U-Boot image > @@ -71,7 +77,7 @@ static int spl_spi_load_image(struct spl_image_info *spl_image, > struct spl_boot_device *bootdev) > { > int err = 0; > - unsigned payload_offs = CONFIG_SYS_SPI_U_BOOT_OFFS; > + unsigned int payload_offs; > struct spi_flash *flash; > struct image_header *header; > > @@ -90,6 +96,8 @@ static int spl_spi_load_image(struct spl_image_info *spl_image, > return -ENODEV; > } > > + payload_offs = spl_spi_get_uboot_raw_sector(flash); I don't really like the function name here "_raw_sector" as this is not a sector number in SPI flash but an address offset. Thanks, Stefan