Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20CBDC433FE for ; Tue, 22 Nov 2022 20:50:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 427D21621; Tue, 22 Nov 2022 21:49:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 427D21621 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669150203; bh=WoqdMSrDh1aSCwbEOBB5q9ekxo7PYzlQpg5zweyNflE=; h=Date:To:References:Subject:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T5OAq3E/at8pO49SrYF5KPz72RMl0F5nUf51MoYtyYkq5ZRjPbvAWHaFNnb0BFGAY 8lk+XXUUqL2Y7TGzV9b2FYEfck98Q7E4B25eUlKZQAWfhBnSAT0NmSK9jRDKvy1hsT 7NQLjtKd9gXAVr/8DKyMf1Pk+4nScD8d1NuWS+Zo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DF3CCF8026A; Tue, 22 Nov 2022 21:49:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1EE73F80272; Tue, 22 Nov 2022 21:49:11 +0100 (CET) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 26486F80149 for ; Tue, 22 Nov 2022 21:49:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 26486F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e50+0O8E" Received: by mail-wm1-x335.google.com with SMTP id l39-20020a05600c1d2700b003cf93c8156dso12262565wms.4 for ; Tue, 22 Nov 2022 12:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=8xzKzCRrQ0kD01ErE8/DSm8QGUxYgutvYGN37un2fEs=; b=e50+0O8ETpq4Otf+oxktx8UlVwPlghSMuG3s/gznq5eMw3JFpyHlvGHOsuwgSS1vBw KxmDQoXQWWczTxhtTMl47jcH6FXEQYfwevU6NrtUm0UbLlt/W/lLomgHws9P7U9+RoWU /WgpdOjrtJ5NQm7/1LSt1lj5RhYS9txXlel9Q+tcLMY7/r+c36jwlWiFYT5Azxnl5WSj JTF7bYvrpBJXhA9T6NvBUmO/EGp+EmEQB4GrXtQ47xh9Bhu56ZAbWuxTdvbhEQBomjvA DmsjykKsMPUVdO2Z7HqT+u8ynkCTzC1gCAFl5xElujyQQWOMky4gcFrDkwe8lXpvb2zy TwuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8xzKzCRrQ0kD01ErE8/DSm8QGUxYgutvYGN37un2fEs=; b=Fg0DJC5sT6cNagIiNmyWrrlk0XiAWVUfYaPvbHzFSc7k1E5zxzBULHOs70heqDAsIt rQ5pObx6UOdh92FL9byexhS3vBbq3FEbZkZn0CfHNDUbXjVBqsyKBEFVG6TY0DWuo623 Tr0S+AsihNLmCPgrcP8jEkmXg+I2q6w4OQAoh9aOv5q9Dsw5JpIFNFEr/QAToAxCYefH YA40W/albv4TcylxZhGOgluWPj3t6bida4I7ea3c/SSIfATftM6ZUsYYPxhadTBFvItj w3d0daF0G1FVB5+6j+HszQ0JnU7ufmL4aI3womcoYqkPTn/BwGgbF9jkKJiCCNv1+xAB 105w== X-Gm-Message-State: ANoB5pmv4xJo/8/LdzifI7OuyVvINRS1o2KCRbVqHjjDeW6bxWiUwJDU WCbpeuTK5215b6AqT2C9E7M= X-Google-Smtp-Source: AA0mqf5luX8xyap/ZIY48+LE5qXXkRRDwsYMk2Qz5GlrYjdqO0IivztM2rUASWdPg1F4GAspr2u2kA== X-Received: by 2002:a05:600c:2241:b0:3cf:9ced:dce4 with SMTP id a1-20020a05600c224100b003cf9ceddce4mr17457810wmm.120.1669150146130; Tue, 22 Nov 2022 12:49:06 -0800 (PST) Received: from [10.10.20.10] (80.49.50.209.ipv4.supernova.orange.pl. [80.49.50.209]) by smtp.gmail.com with ESMTPSA id u10-20020a7bc04a000000b003c6bd12ac27sm17745612wmc.37.2022.11.22.12.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 12:49:05 -0800 (PST) Message-ID: <77f06a82-6765-4e7e-d30e-554acb8309b2@gmail.com> Date: Tue, 22 Nov 2022 21:49:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: cezary.rojewski@intel.com References: Subject: Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL Content-Language: en-GB From: Alicja Michalska In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, upstream@semihalf.com, rad@semihalf.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, ahplka19@gmail.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hello Czarek, trying to re-send that mail from my workstation since email client on my phone didn't cc properly. No, I've got no idea why it's been duplicated. It's my first time contributing to mainline, so sorry about that. Will double-check my patches in the future. On 22/11/2022 19:10, Cezary Rojewski wrote: > On 2022-11-22 12:20 AM, Alicja Michalska wrote: >> KBL platform is missing the definition of 'max98357a' audio amplifier. >> This amplifier is used on many KBL Chromebooks, for instance variant >> 'nami' of 'Google/poppy' baseboard. >> >> Reported-by: CoolStar >> Signed-off-by: Alicja Michalska >> >> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c >> index 87f9c18be238..650faebb33ef 100644 >> --- a/sound/soc/intel/avs/board_selection.c >> +++ b/sound/soc/intel/avs/board_selection.c >> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { >>           }, >>           .tplg_filename = "max98373-tplg.bin", >>       }, >> +    { >> +        .id = "MX98357A", >> +        .drv_name = "avs_max98357a", >> +        .mach_params = { >> +            .i2s_link_mask = AVS_SSP(0), >> +        }, >> +        .tplg_filename = "max98357a-tplg.bin", >> +    }, >>       { >>           .id = "DLGS7219", >>           .drv_name = "avs_da7219", >> --- >>   sound/soc/intel/avs/board_selection.c | 8 ++++++++ >>   1 file changed, 8 insertions(+) >> >> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c >> index 87f9c18be238..650faebb33ef 100644 >> --- a/sound/soc/intel/avs/board_selection.c >> +++ b/sound/soc/intel/avs/board_selection.c >> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = { >>           }, >>           .tplg_filename = "max98373-tplg.bin", >>       }, >> +    { >> +        .id = "MX98357A", >> +        .drv_name = "avs_max98357a", >> +        .mach_params = { >> +            .i2s_link_mask = AVS_SSP(0), >> +        }, >> +        .tplg_filename = "max98357a-tplg.bin", >> +    }, >>       { >>           .id = "DLGS7219", >>           .drv_name = "avs_da7219", > > > Any reason why diff is repeated twice? It seems that the first copy of diff is part of the commit message.