From: "flichtenheld (Code Review)" Date: Fri, 16 Feb 2024 16:01:38 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: <77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="wNnuhGHywwg="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: Fix bug preventing proxy credentials caching. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --wNnuhGHywwg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/523?usp=3Demail ) Change subject: Http-proxy: Fix bug preventing proxy credentials caching. ...................................................................... Patch Set 1: Code-Review-2 (5 comments) Patchset: PS1: Definitely has issues File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/a2ced5bd_47c89245 : PS1, Line 1861: SHOW_BOOL(ce.http_proxy_options->nocache); This belongs into show_connection_entry like the other o->ce options File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/99f3b845_b241aa5b : PS1, Line 275: if (!static_proxy_user_pass.defined || (is_first_time &&= !p->options.nocache) ) This condition feels wrong to me. As I understand the code this should neve= r be true when p->options.nocache is true. Or do I understand the code wron= g? http://gerrit.openvpn.net/c/openvpn/+/523/comment/67ae3287_17906ea3 : PS1, Line 278: p->options.auth_file, I think you messed up a rebase on top of a634cc5eccd55f1d14197da7376bb819bd= f72cb6 here. Your code ignores auth_file_up again. http://gerrit.openvpn.net/c/openvpn/+/523/comment/3303fbc3_b1eee104 : PS1, Line 546: get_user_pass_http(p); So previously this forced a reset of the credentials. This you removed. Are= you sure this is correct? If yes, why? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Fri, 16 Feb 2024 16:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --wNnuhGHywwg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

5 comments:

  • Patchset:

  • File src/openvpn/options.c:

    • Patch Set #1, Line 1861: SHOW_BOOL(ce.http_proxy_o= ptions->nocache);

      This belongs into show_connection_entry like the other o->= ;ce options

  • File = src/openvpn/proxy.c:

    • Patch Set #1, Line 275: if (!static_proxy_user_pass.defined || (is_first_time && !p-= >options.nocache) )

      This condition feels wrong to me. As I understand the code= this should never be true when p->options.nocache is true. Or do I unde= rstand the code wrong?

    • Patch Set #1, Line 278: p->option= s.auth_file,

      I think you messed up a rebase on top of a634cc5eccd55f1d14197da7376= bb819bdf72cb6 here. Your code ignores auth_file_up again.

    • = Patch Set #1, Line 546: get_user_pass_http(p);

      So previously this forced a reset of the credenti= als. This you removed. Are you sure this is correct? If yes, why?

    • <= /ul>

    To view, visit change 523. To unsubscribe, or for help writing = mail filters, visit settings= .

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279= fb71c01a1a78a
    Gerrit-Change-Number: 523
    Gerrit-PatchSet: 1
    Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
    Gerrit-Comment-Date: Fri, 16 Feb 2024 16:01:38= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --wNnuhGHywwg=--