From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v3 4/7] s390x: compile sclp-ascii.c Date: Mon, 22 May 2017 11:47:38 +0200 Message-ID: <78138122-02c8-6744-4dcf-9ff7ba8e3b30@redhat.com> References: <20170522085702.17856-1-david@redhat.com> <20170522085702.17856-5-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Christian Borntraeger , Cornelia Huck To: David Hildenbrand , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757877AbdEVJrp (ORCPT ); Mon, 22 May 2017 05:47:45 -0400 In-Reply-To: <20170522085702.17856-5-david@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 22.05.2017 10:56, David Hildenbrand wrote: > We can reuse strlen and memcpy. __pa(x) is already defined in page.h > We don't have (and need) defines for error values and consuming sclp > irqs is not required, as we won't be passing control to some other OS. > > Signed-off-by: David Hildenbrand > --- > lib/s390x/sclp-ascii.c | 28 +++++++--------------------- > lib/s390x/sclp.h | 2 -- > s390x/Makefile | 1 + > 3 files changed, 8 insertions(+), 23 deletions(-) Reviewed-by: Thomas Huth