Content-Type: multipart/mixed; boundary="===============1827887279984885278=="
MIME-Version: 1.0
From: John Hubbard <jhubbard@nvidia.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] mm/gup: try_pin_compound_head() can be static
Date: Tue, 17 Dec 2019 05:56:56 -0800
Message-ID: <7828a101-e422-8e2a-ef9b-9c0285065ed5@nvidia.com>
In-Reply-To: <20191217080358.q3k57ta62txvip5h@4978f4969bb8>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============1827887279984885278==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On 12/17/19 12:03 AM, kbuild test robot wrote:
> =

> Fixes: 8086d1c61970 ("mm/gup: track FOLL_PIN pages")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>   gup.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/mm/gup.c b/mm/gup.c
> index 038b71165a761..849a6f55938e6 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -75,7 +75,7 @@ static inline struct page *try_get_compound_head(struct=
 page *page, int refs)
>    * @Return:	the compound head page, with ref appropriately incremented,
>    * or NULL upon failure.
>    */
> -__must_check struct page *try_pin_compound_head(struct page *page, int r=
efs)
> +static __must_check struct page *try_pin_compound_head(struct page *page=
, int refs)
>   {
>   	struct page *head =3D try_get_compound_head(page,
>   						  GUP_PIN_COUNTING_BIAS * refs);
> =


Yes, it should have been declared static. And this also applies to the late=
st version
(v11). The preferred fix would stay within 80 columns, like this:

diff --git a/mm/gup.c b/mm/gup.c
index c2793a86450e..39b2f683bd2e 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -75,7 +75,8 @@ static inline struct page *try_get_compound_head(struct p=
age *page, int refs)
   * @Return:    the compound head page, with ref appropriately incremented,
   * or NULL upon failure.
   */
-__must_check struct page *try_pin_compound_head(struct page *page, int ref=
s)
+static __must_check struct page *try_pin_compound_head(struct page *page,
+                                                      int refs)
  {
         struct page *head =3D try_get_compound_head(page,
                                                   GUP_PIN_COUNTING_BIAS * =
refs);


thanks,
-- =

John Hubbard
NVIDIA
--===============1827887279984885278==--