From: Heiner Kallweit Subject: [PATCH net-next 06/11] r8169: remove print_mac_version Date: Mon, 19 Nov 2018 22:36:15 +0100 Message-ID: <784acea8-103a-fedc-25b0-651f1d4dc026@gmail.com> References: <7484b166-100b-52b9-1539-22e9199a8a3a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: David Miller , Realtek linux nic maintainers Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:35237 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731168AbeKTIHi (ORCPT ); Tue, 20 Nov 2018 03:07:38 -0500 Received: by mail-wr1-f67.google.com with SMTP id 96so16731199wrb.2 for ; Mon, 19 Nov 2018 13:42:00 -0800 (PST) In-Reply-To: <7484b166-100b-52b9-1539-22e9199a8a3a@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: The syslog message printed on driver load allows to easily identify the mac version number (based on chip name and XID). So we don't need this extra debug message which is wrong anyway because e.g. RTL_GIGA_MAC_VER_01 has value 0. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index ee6458070..a6b12adbc 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -2170,11 +2170,6 @@ static void rtl8169_get_mac_version(struct rtl8169_private *tp, } } -static void rtl8169_print_mac_version(struct rtl8169_private *tp) -{ - netif_dbg(tp, drv, tp->dev, "mac_version = 0x%02x\n", tp->mac_version); -} - struct phy_reg { u16 reg; u16 val; @@ -3897,8 +3892,6 @@ static void rtl_hw_phy_config(struct net_device *dev) { struct rtl8169_private *tp = netdev_priv(dev); - rtl8169_print_mac_version(tp); - switch (tp->mac_version) { case RTL_GIGA_MAC_VER_01: break; @@ -7340,8 +7333,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) rtl_init_mdio_ops(tp); rtl_init_jumbo_ops(tp); - rtl8169_print_mac_version(tp); - chipset = tp->mac_version; rc = rtl_alloc_irq(tp); -- 2.19.1