From: Michel Thierry Subject: Re: [PATCH] drm/i915/guc: Don't make assumptions while getting the lrca offset Date: Tue, 11 Jul 2017 17:14:46 -0700 Message-ID: <7886e4fe-533d-ed60-8a2d-d2534467e8c9@intel.com> References: <20170711212939.12185-1-michel.thierry@intel.com> <149981264355.28871.1114774176461935999@mail.alporthouse.com> <149981760221.28871.14164331043471599204@mail.alporthouse.com> <149981806045.28871.3423216070968756838@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EBB789CE1 for ; Wed, 12 Jul 2017 00:14:50 +0000 (UTC) In-Reply-To: <149981806045.28871.3423216070968756838@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gNy8xMS8yMDE3IDU6MDcgUE0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIENocmlz IFdpbHNvbiAoMjAxNy0wNy0xMiAwMTowMDowMikKPj4gQWxzbyBmZWVsIGZyZWUgdG8gdHJ5IGFu ZCBmaXh1cCB0aGUgb3RoZXIgY29uZnVzaW9uIGluIGludGVsX2xyYy5jLgo+PiBQZXJoYXBzIHNv bWV0aGluZyBsaWtlOgo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiBpbmRleCBiMDcz OGQyLi5mNDk4YWE2IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+PiBAQCAtMjAz MSw4ICsyMDMxLDkgQEAgc3RhdGljIGludCBleGVjbGlzdHNfY29udGV4dF9kZWZlcnJlZF9hbGxv YyhzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+PiAgIAo+PiAgICAgICAgICBjb250ZXh0 X3NpemUgPSByb3VuZF91cChlbmdpbmUtPmNvbnRleHRfc2l6ZSwgSTkxNV9HVFRfUEFHRV9TSVpF KTsKPj4gICAKPj4gLSAgICAgICAvKiBPbmUgZXh0cmEgcGFnZSBhcyB0aGUgc2hhcmluZyBkYXRh IGJldHdlZW4gZHJpdmVyIGFuZCBHdUMgKi8KPj4gLSAgICAgICBjb250ZXh0X3NpemUgKz0gUEFH RV9TSVpFICogTFJDX1BQSFdTUF9QTjsKPj4gKyAgICAgICAvKiBBZGQgYW4gZXh0cmEgcGFnZSBh dCB0aGUgc3RhcnQgZm9yIHNoYXJpbmcgZGF0YSB3aXRoIHRoZSBHdUMgKi8KPj4gKyAgICAgICBC VUlMRF9CVUdfT04oTFJDX1BQSFdTUF9QTiAhPSAxKTsKPj4gKyAgICAgICBjb250ZXh0X3NpemUg Kz0gUEFHRV9TSVpFOwo+PiAgIAo+PiAgICAgICAgICBjdHhfb2JqID0gaTkxNV9nZW1fb2JqZWN0 X2NyZWF0ZShjdHgtPmk5MTUsIGNvbnRleHRfc2l6ZSk7Cj4+ICAgICAgICAgIGlmIChJU19FUlIo Y3R4X29iaikpIHsKPiAKPiBPciBiZXR0ZXIKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IGluZGV4IGIwNzM4ZDIuLjBiN2ZiMzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IEBAIC0yMDMxLDggKzIwMzEsOCBAQCBzdGF0aWMgaW50IGV4ZWNsaXN0c19jb250ZXh0X2RlZmVy cmVkX2FsbG9jKHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gICAKPiAgICAgICAgICBj b250ZXh0X3NpemUgPSByb3VuZF91cChlbmdpbmUtPmNvbnRleHRfc2l6ZSwgSTkxNV9HVFRfUEFH RV9TSVpFKTsKPiAgIAo+IC0gICAgICAgLyogT25lIGV4dHJhIHBhZ2UgYXMgdGhlIHNoYXJpbmcg ZGF0YSBiZXR3ZWVuIGRyaXZlciBhbmQgR3VDICovCj4gLSAgICAgICBjb250ZXh0X3NpemUgKz0g UEFHRV9TSVpFICogTFJDX1BQSFdTUF9QTjsKPiArICAgICAgIC8qIEFkZCBhbiBleHRyYSBwYWdl IGF0IHRoZSBzdGFydCBmb3Igc2hhcmluZyBkYXRhIHdpdGggdGhlIEd1QyAqLwo+ICsgICAgICAg Y29udGV4dF9zaXplICs9IExSQ19HVUNTSFJfUEFHRVMgKiBQQUdFX1NJWkU7Cj4gICAKPiAgICAg ICAgICBjdHhfb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZShjdHgtPmk5MTUsIGNvbnRleHRf c2l6ZSk7Cj4gICAgICAgICAgaWYgKElTX0VSUihjdHhfb2JqKSkgewo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5oCj4gaW5kZXggNTJiM2ExZi4uODQ4Y2EyMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5oCj4gQEAgLTcyLDcgKzcyLDggQEAgaW50IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdChz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICAgCj4gICAvKiBPbmUgZXh0cmEgcGFn ZSBpcyBhZGRlZCBiZWZvcmUgTFJDIGZvciBHdUMgYXMgc2hhcmVkIGRhdGEgKi8KPiAgICNkZWZp bmUgTFJDX0dVQ1NIUl9QTiAgKDApCj4gLSNkZWZpbmUgTFJDX1BQSFdTUF9QTiAgKExSQ19HVUNT SFJfUE4gKyAxKQo+ICsjZGVmaW5lIExSQ19HVUNTSFJfUEFHRVMgMQo+ICsjZGVmaW5lIExSQ19Q UEhXU1BfUE4gIChMUkNfR1VDU0hSX1BOICsgTFJDX0dVQ1NIUl9QQUdFUykKPiAgICNkZWZpbmUg TFJDX1NUQVRFX1BOICAgKExSQ19QUEhXU1BfUE4gKyAxKQo+ICAgCj4gICBzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZTsKPiAKPiBOb3doZXJlIGRvIHdlIHVzZSBMUkNfR1VDU0hSX1BOLiBIYXZpbmcg aXQganVzdCBnaXZlcyB1cyB0aGUgbWlyYWdlIG9mCj4gZmxleGliaWxpdHkuLi4KCkxSQ19HVUNT SFJfUE4gaXMgbm90IHVzZWQgYmVjYXVzZSBwZW9wbGUgYXNzdW1lZCBpdCBpcyBhbHdheXMgcGFn ZSAwIG9mIAp0aGUga2VybmVsIGN0eCA6UwoKT25lIG1vcmUgdGhpbmcgdG8gZml4LCB1c2UgTFJD X0dVQ1NIUl9QTiBpbiBhbGwgdGhlIHBsYWNlcyB3aGVyZSB0aGlzIApfc2hhcmVkXyBHdUMgcGFn ZSBpcyB1c2VkIChndWNfZ2d0dF9vZmZzZXQoY3R4LT5lbmdpbmVbUkNTXS5zdGF0ZSkpCgo+IC1D aHJpcwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK