Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A68FC433EF for ; Fri, 15 Apr 2022 07:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242018AbiDOHkf (ORCPT ); Fri, 15 Apr 2022 03:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbiDOHkf (ORCPT ); Fri, 15 Apr 2022 03:40:35 -0400 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CBC947565 for ; Fri, 15 Apr 2022 00:38:01 -0700 (PDT) Message-ID: <789cfa63-55f9-0074-1245-ad38a6fe8bf8@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1650008280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rol7JR4SzFpzKoAuZ5+4M1Lbb3cJuzsNhJ2da471FD0=; b=KvAj8lKhbKiEvqHEeGzNU8z8kTUjhS4rbkyOV8HRQbDIMdglUpXCF20ZB1UJITIfHCY0jF wbh0pgLMqyLdoKcMcPXZU02H9Je2MlL6MvgIqxK+DY+PuntnZZ/cQvJKBSDocnITCTREX8 I0/rqO9b2OJABHYtOlf1RcIlpNk5xRM= Date: Fri, 15 Apr 2022 15:37:48 +0800 MIME-Version: 1.0 Subject: Re: blktest failures To: Bob Pearson , Christoph Hellwig , Bart Van Assche Cc: "Martin K. Petersen" , Jason Gunthorpe , "linux-rdma@vger.kernel.org" , Yi Zhang References: <533dc3b0-e58a-0bc8-2f07-5dbfb3d1235e@gmail.com> <28b4c636-c5a7-451b-965b-6201ac5af460@gmail.com> <98f2a27d-7fa6-074f-a3e5-6b172c79ccd7@acm.org> <20220409050405.GA17755@lst.de> <8ff53db7-137f-8d29-18e7-3926de255deb@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanjun Zhu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org 在 2022/4/15 15:29, Bob Pearson 写道: > On 4/15/22 02:12, Yanjun Zhu wrote: >> 在 2022/4/10 5:43, Bob Pearson 写道: >>> On 4/9/22 00:04, Christoph Hellwig wrote: >>>> On Fri, Apr 08, 2022 at 04:25:12PM -0700, Bart Van Assche wrote: >>>>> One of the functions in the above call stack is sd_remove(). sd_remove() >>>>> calls del_gendisk() just before calling sd_shutdown(). sd_shutdown() >>>>> submits the SYNCHRONIZE CACHE command. In del_gendisk() I found the >>>>> following comment: "Fail any new I/O". Do you agree that failing new I/O >>>>> before sd_shutdown() is called is wrong? Is there any other way to fix this >>>>> than moving the blk_queue_start_drain() etc. calls out of del_gendisk() and >>>>> into a new function? >>>> That SYNCHRONIZE CACHE is a passthrough command sent on the request_queue >>>> and should not be affected by stopping all file system I/O. >>> When I run check -q srp >>> all the test cases pass but each one stops for 3+ minutes at synchronize cache. >>> The rxe device is still active until sync cache returns when the last QP and the PD >>> are destroyed. It may be that the queues are blocked waiting for something else >>> even though they have reported success?? >> If you remove all the xarray patches and use the original source code. This will not occur. >> >> Zhu Yanjun >> > I missed one other point. The 3 minute delay is actually not a rxe bug at all but was recently > caused by a bad scsi patch which has since been reverted. I am not sure about this because wr NULL problem exists with xarray patches. Please let us find the root cause of wr NULL. This can make RXE more stable. Zhu Yanjun