Received: from eggs.gnu.org ([209.51.188.92]:56389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx6Jk-0008T9-2Z for qemu-devel@nongnu.org; Fri, 22 Feb 2019 03:36:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gx6Ja-0006k4-UC for qemu-devel@nongnu.org; Fri, 22 Feb 2019 03:36:16 -0500 References: <20190222081153.14206-1-david@redhat.com> <20190222081153.14206-3-david@redhat.com> From: Thomas Huth Message-ID: <78efbbc5-330c-7c14-e00d-fdc2fb8b06a4@redhat.com> Date: Fri, 22 Feb 2019 09:36:02 +0100 MIME-Version: 1.0 In-Reply-To: <20190222081153.14206-3-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 2/3] s390x: use a QEMU-style typedef + name for SIGP save area struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Halil Pasic , Christian Borntraeger , Janosch Frank , Cornelia Huck , Richard Henderson On 22/02/2019 09.11, David Hildenbrand wrote: > Convert this to QEMU style. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index f3fcf96482..a7edd5df7d 100644 > --- a/target/s390x/helper.c > +++ b/target/s390x/helper.c > @@ -211,7 +211,7 @@ void s390_cpu_recompute_watchpoints(CPUState *cs) > } > } > > -struct sigp_save_area { > +typedef struct SigpSaveArea { > uint64_t fprs[16]; /* 0x0000 */ > uint64_t grs[16]; /* 0x0080 */ > PSW psw; /* 0x0100 */ > @@ -225,13 +225,13 @@ struct sigp_save_area { > uint8_t pad_0x0138[0x0140 - 0x0138]; /* 0x0138 */ > uint32_t ars[16]; /* 0x0140 */ > uint64_t crs[16]; /* 0x0384 */ > -}; > -QEMU_BUILD_BUG_ON(sizeof(struct sigp_save_area) != 512); > +} SigpSaveArea; > +QEMU_BUILD_BUG_ON(sizeof(SigpSaveArea) != 512); > > int s390_store_status(S390CPU *cpu, hwaddr addr, bool store_arch) > { > static const uint8_t ar_id = 1; > - struct sigp_save_area *sa; > + SigpSaveArea *sa; > hwaddr len = sizeof(*sa); > int i; Reviewed-by: Thomas Huth