Return-Path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:38019 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbeHQSdm (ORCPT ); Fri, 17 Aug 2018 14:33:42 -0400 Received: by mail-wm0-f52.google.com with SMTP id t25-v6so7706923wmi.3 for ; Fri, 17 Aug 2018 08:29:53 -0700 (PDT) Subject: Re: [PATCH v3 2/3] kernel-shark-qt: Add I/O for configuration data. To: Steven Rostedt Cc: linux-trace-devel@vger.kernel.org References: <20180816150729.4680-1-y.karadz@gmail.com> <20180816150729.4680-2-y.karadz@gmail.com> <20180816145219.7e91e435@gandalf.local.home> <0a535d0f-333c-f002-970c-33c5a8937b05@gmail.com> <20180817084958.11361418@gandalf.local.home> <38b58799-95e7-53c0-8398-2b590dfb1192@gmail.com> <20180817105842.7f14e6e7@gandalf.local.home> <20180817111245.64a2ffcc@gandalf.local.home> From: "Yordan Karadzhov (VMware)" Message-ID: <7949286d-dd20-3ec7-4d8f-4e8356432f84@gmail.com> Date: Fri, 17 Aug 2018 18:29:49 +0300 MIME-Version: 1.0 In-Reply-To: <20180817111245.64a2ffcc@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org List-ID: On 17.08.2018 18:12, Steven Rostedt wrote: > On Fri, 17 Aug 2018 18:09:44 +0300 > "Yordan Karadzhov (VMware)" wrote: > >> On 17.08.2018 17:58, Steven Rostedt wrote: >>> And we can have more than one file saved in the session. Hmm, I wonder >>> if we should add code to see if files still exist, and remove the >>> information if they do not. >> >> Actually if you use this a lot you may have a big number of *.json files >> in your work directory. And some of these files can represent sessions, >> some other only filters. But when you click on the Session Import, for >> example, the Open File dialog will show you all *.json files. In this >> case you may get confused and try to open a wrong file. This is the >> reason why we need the "type" field. >> > > I was actually thinking of having a single json file that stores all > "full sessions". Like a .viminfo file. This is a good idea. But we have to support saving individual sessions as well. Mainly for bug reports. In my work directory I have a lot of files called bugXX.json ;-) Actually we can add a menu for creating a tarball containing trace.dat and session.json. Yordan The specific filters and such > should probably be in separate files as that would be how people could > load and save them. > > -- Steve >