From: Maarten Lankhorst Subject: Re: [PATCH] drm: Move property validation to a helper. Date: Wed, 7 Sep 2016 11:17:21 +0200 Message-ID: <796e6c61-2931-89f8-e399-f00ea1f99b3d@linux.intel.com> References: <1473062773-5045-1-git-send-email-maarten.lankhorst@linux.intel.com> <0ebc25a7-3441-c4ff-49b6-ffed95244bdd@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0ebc25a7-3441-c4ff-49b6-ffed95244bdd@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Intel Graphics Development , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T3AgMDctMDktMTYgb20gMTA6NTggc2NocmVlZiBNYWFydGVuIExhbmtob3JzdDoKPiBQcm9wZXJ0 eSBsaWZldGltZXMgYXJlIGVxdWFsIHRvIHRoZSBkZXZpY2UgbGlmZXRpbWUsIHNvIHRoZSBzZXBh cmF0ZQo+IGRybV9wcm9wZXJ0eV9maW5kIGlzIG5vdCBuZWVkZWQuIFRoZSBwb2ludGVyIGNhbiBi ZSByZXRyaWV2ZWQgZnJvbQo+IHRoZSBwcm9wZXJ0aWVzIG1lbWJlciwgd2hpY2ggc2F2ZXMgdXMg c29tZSBsb2NraW5nIGFuZCBhIGV4dHJhIGxvb2t1cC4KPgo+IFRoZSBsaWZldGltZSBmb3IgcHJv cGVydGllcyBpcyB1bnRpbCB0aGUgZGV2aWNlIGlzIGRlc3Ryb3llZCwgd2hpY2gKPiBoYXBwZW5z IGxhdGUgaW4gdGhlIGRldmljZSB1bmxvYWQgcGF0aC4KPgo+IFRlc3RjYXNlOiBrbXNfcHJvcGVy dGllcwo+IFN1Z2dlc3RlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jICAgICAgICB8IDE2ICsrKystLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjX2ludGVybmFsLmggfCAgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX21vZGVfb2Jq ZWN0LmMgICB8IDMxICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMyBmaWxlcyBj aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWMuYwo+IGluZGV4IGZhYzE1NmM0MzUwNi4uOGJlYzg0NjY3ODFjIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jCj4gQEAgLTE2MDksNyArMTYwOSw3IEBAIGludCBkcm1fbW9kZV9hdG9taWNfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZTsKPiAgCXVuc2lnbmVkIHBsYW5lX21hc2s7Cj4gIAlpbnQgcmV0ID0gMDsKPiAtCXVuc2ln bmVkIGludCBpLCBqLCBrOwo+ICsJdW5zaWduZWQgaW50IGksIGo7Cj4gIAo+ICAJLyogZGlzYWxs b3cgZm9yIGRyaXZlcnMgbm90IHN1cHBvcnRpbmcgYXRvbWljOiAqLwo+ICAJaWYgKCFkcm1fY29y ZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX0FUT01JQykpCj4gQEAgLTE2OTEsMTkgKzE2OTEs MTEgQEAgcmV0cnk6Cj4gIAkJCQlnb3RvIG91dDsKPiAgCQkJfQo+ICAKPiAtCQkJZm9yIChrID0g MDsgayA8IG9iai0+cHJvcGVydGllcy0+Y291bnQ7IGsrKykKPiAtCQkJCWlmIChvYmotPnByb3Bl cnRpZXMtPnByb3BlcnRpZXNba10tPmJhc2UuaWQgPT0gcHJvcF9pZCkKPiAtCQkJCQlicmVhazsK PiAtCj4gLQkJCWlmIChrID09IG9iai0+cHJvcGVydGllcy0+Y291bnQpIHsKPiAtCQkJCXJldCA9 IC1FSU5WQUw7Cj4gLQkJCQlnb3RvIG91dDsKPiAtCQkJfQo+IC0KPiAtCQkJcHJvcCA9IGRybV9w cm9wZXJ0eV9maW5kKGRldiwgcHJvcF9pZCk7Cj4gKwkJCXByb3AgPSBkcm1fbW9kZV9vYmpfZmlu ZF9wcm9wX2lkKG9iaiwgcHJvcF9pZCk7Cj4gIAkJCWlmICghcHJvcCkgewo+ICAJCQkJZHJtX21v ZGVfb2JqZWN0X3VucmVmZXJlbmNlKG9iaik7Cj4gLQkJCQlyZXQgPSAtRU5PRU5UOwo+ICsJCQkJ RFJNX0RFQlVHX0FUT01JQygiY2Fubm90IGZpbmQgcHJvcGVydHkgJXUgZm9yIG9iaiAldVxuIiwg cHJvcF9pZCwgb2JqX2lkKTsKPiArCQkJCXJldCA9IC1FSU5WQUw7ClRoaXMgbmVlZHMgdG8gc3Rh eSAtRU5PRU5UIGl0IHNlZW1zLiBrbXNfYXRvbWljIHRlc3RjYXNlIHJlbGllcyBvbiBpdC4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==