Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8784C636D6 for ; Thu, 9 Feb 2023 17:01:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 74F3F85CF2; Thu, 9 Feb 2023 18:01:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="Yq4FQTUl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 87C9985CC8; Thu, 9 Feb 2023 18:01:53 +0100 (CET) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BBA1885F26 for ; Thu, 9 Feb 2023 18:01:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=souajih@baylibre.com Received: by mail-wr1-x433.google.com with SMTP id bu23so2432397wrb.8 for ; Thu, 09 Feb 2023 09:01:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6QR+xTQrbQvfoZg1WSvyN2X+1F2XhMJ3X6hyDi/o3ho=; b=Yq4FQTUlumzukSe9Yu/m+7hKCRBZbOjpBgaw9ZXyl7Lg8MRwoUNHmX1G2Lx73dquJ0 5pNFzTd6EGmyHzmRrkFw8h9hTdLUS3qa25eBfmGD03OOD8JtcT9gtSVSbzia/rOz+t+3 x5WiRjOLPIOXMOu1VzTdUm+q/xsxfxgpAcMeXOBbT9o5ljgUB+tjM7lOeK9wzqUa4W9M kBVLE1Iw5uvBms9jhm5S6GstI50XhKebCrL7UR8ipVZMDuwWYCpfuyHIOiwdvBlbCceU jelnc+wq8qOZzARFvSCRg7QQKse0Pd34XRodSK89yKX69/pOcxM1R+8AqeziK4ed+ptL W3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6QR+xTQrbQvfoZg1WSvyN2X+1F2XhMJ3X6hyDi/o3ho=; b=SPFoe7j8KZuk1MbmF4MWL37urfcvfeGKIihlvBMbuhi4vBQVpjfMc0Ve0rJDtapwya DZVUkb+Gf0nLRxsI51tNBQiR22qj+nxIfdbnbtzltNHRdq3Xnk04xbhC6EnRzYhwQnI9 kaOzUwBTWjntvQ+9zrvUc/41lLf4V5aeGKcKJwdJM3EETwhOLzuqSI0396/tVDrgjZDP yRTizGUDF1Jzj0XP1TkQ5XsfBl4aZfZZaJih9Co2xSaWbMTV1YOqI9Y3Ce9yw4YG/bcD ZKI5E8Q9t6yXCXrbLcnK4SCPRFYAjuOec4QvILGGXV/FXLNgvz2hed4nlFbxxM0wS2eq 3tng== X-Gm-Message-State: AO0yUKUkQWOHlIZa/3pGrnkNGyGQ4QqrOLb6NsOES7FaarG0H/9nOyce uHCTaT0mu9Vhn+ZkGETQ9pmu/A== X-Google-Smtp-Source: AK7set99VuTgrETc5xPiiOq+TcDMudKpTJQbF8/Ye357TXmZ3wvKRDiNrNftdpu0C9eiV9uqgiPF7g== X-Received: by 2002:adf:d845:0:b0:2c3:e69a:eecf with SMTP id k5-20020adfd845000000b002c3e69aeecfmr13650557wrl.8.1675962110209; Thu, 09 Feb 2023 09:01:50 -0800 (PST) Received: from [10.2.3.222] (lfbn-nic-1-295-18.w90-116.abo.wanadoo.fr. [90.116.132.18]) by smtp.gmail.com with ESMTPSA id d1-20020adffd81000000b002bfe08c566fsm1620020wrr.106.2023.02.09.09.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 09:01:49 -0800 (PST) Message-ID: <79ea2e45-fd43-2e41-c705-84b1bcd47d9d@baylibre.com> Date: Thu, 9 Feb 2023 18:01:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3,v4 support Content-Language: en-US To: Simon Glass Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, mkorpershoek@baylibre.com, glaroque@baylibre.com, khilman@baylibre.com References: <20230205235021.355410-1-souajih@baylibre.com> <20230205235021.355410-10-souajih@baylibre.com> From: Safae Ouajih In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 07/02/2023 05:02, Simon Glass wrote: > On Sun, 5 Feb 2023 at 16:50, Safae Ouajih wrote: >> Introduce vendor boot image for version 3 and 4 of boot image header. >> The vendor boot image will hold extra information about kernel, dtb >> and ramdisk. >> >> This is done to prepare for boot image version 3 and 4 support. >> >> Signed-off-by: Safae Ouajih >> --- >> boot/bootm.c | 8 +++---- >> boot/image-android.c | 54 ++++++++++++++++++++++++++++---------------- >> boot/image-board.c | 3 +-- >> boot/image-fdt.c | 3 ++- >> cmd/abootimg.c | 4 ++-- >> include/image.h | 48 ++++++++++++++++++++++++++++++--------- >> 6 files changed, 81 insertions(+), 39 deletions(-) > I don't see a change log but I see some comments. Not sure what else I > said on the review. Only the comments changed to add the new partition Thank you for the review, BR, Safae > Reviewed-by: Simon Glass