From: Mahesh Kumar Subject: Re: [PATCH 4/8] drm/i915: Use intel_atomic_get_new_crtc_state in intel_fbc.c Date: Tue, 1 Aug 2017 13:30:53 +0530 Message-ID: <79fd3a30-0082-a2e5-55e9-a7b383edcd31@intel.com> References: <20170720131519.30104-1-maarten.lankhorst@linux.intel.com> <20170720131519.30104-5-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1776747532==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id D567F6EAA6 for ; Tue, 1 Aug 2017 07:56:40 +0000 (UTC) In-Reply-To: <20170720131519.30104-5-maarten.lankhorst@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1776747532== Content-Type: multipart/alternative; boundary="------------08D9DB8842EAF4D433C377B3" Content-Language: en-US This is a multi-part message in MIME format. --------------08D9DB8842EAF4D433C377B3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, patch looks ok to me. Reviewed-by: Mahesh Kumar On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote: > The previous commit added intel_atomic_get_new_crtc_state, > convert intel_fbc.c to the new helper. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_fbc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > index 860b8c26d29b..81d156f04db9 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -1046,7 +1046,7 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv, > > /* Does this atomic commit involve the CRTC currently tied to FBC? */ > if (fbc->crtc && > - !drm_atomic_get_existing_crtc_state(state, &fbc->crtc->base)) > + !intel_atomic_get_new_crtc_state(state, fbc->crtc)) > goto out; > > if (!intel_fbc_can_enable(dev_priv)) > @@ -1071,8 +1071,7 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv, > if (fbc_on_plane_a_only(dev_priv) && crtc->plane != PLANE_A) > continue; > > - intel_crtc_state = to_intel_crtc_state( > - drm_atomic_get_existing_crtc_state(state, &crtc->base)); > + intel_crtc_state = intel_atomic_get_new_crtc_state(state, crtc); > > intel_crtc_state->enable_fbc = true; > crtc_chosen = true; --------------08D9DB8842EAF4D433C377B3 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi,

patch looks ok to me.

Reviewed-by: Mahesh Kumar <mahesh1.kumar@intel.com>


On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote:
The previous commit added intel_atomic_get_new_crtc_state,
convert intel_fbc.c to the new helper.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_fbc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 860b8c26d29b..81d156f04db9 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -1046,7 +1046,7 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv,
 
 	/* Does this atomic commit involve the CRTC currently tied to FBC? */
 	if (fbc->crtc &&
-	    !drm_atomic_get_existing_crtc_state(state, &fbc->crtc->base))
+	    !intel_atomic_get_new_crtc_state(state, fbc->crtc))
 		goto out;
 
 	if (!intel_fbc_can_enable(dev_priv))
@@ -1071,8 +1071,7 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv,
 		if (fbc_on_plane_a_only(dev_priv) && crtc->plane != PLANE_A)
 			continue;
 
-		intel_crtc_state = to_intel_crtc_state(
-			drm_atomic_get_existing_crtc_state(state, &crtc->base));
+		intel_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
 
 		intel_crtc_state->enable_fbc = true;
 		crtc_chosen = true;

--------------08D9DB8842EAF4D433C377B3-- --===============1776747532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1776747532==--