Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AE4ECE58E for ; Thu, 17 Oct 2019 15:08:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E5B20820 for ; Thu, 17 Oct 2019 15:08:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WnIHJVj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E5B20820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FVB86IM8gKdPfW2WDkLScazUr3/ftM/+4mRewYmNKBA=; b=WnIHJVj20J0IxSk7BIJ6NQ0Rb tjs7KVYL597oSCkWawP6qDXAo4echiCTkkps0NSMr7Tvd+sm1h57tNc8yrOENLt7+i+7Q2Axi+QBF GpJv/LXYlXKBMSf2bzlMKw0FJbmymZglQTLfLsVqZyPZhKGTTtAG99qUfN9pwzau7hThI9VNn7eks 83ww7ljsRZpltiRriktMR5stkDe3jZOJb202rHeeRKvM8lNJ4olA7dSMyakAKnzgHfDV8aE/V+lsz Ubs6fpwiptt+XQ/BV9/08JgLlmb5qCg4RTMnxd9cfyy/JINXM0Dzx7MkHFjrGeZMa3hg+bao2J0Q/ AaDAVHelQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL7OG-0008PM-9N; Thu, 17 Oct 2019 15:08:36 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL7OC-0008O6-BU for linux-nvme@lists.infradead.org; Thu, 17 Oct 2019 15:08:34 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 521EC30860D7; Thu, 17 Oct 2019 15:08:31 +0000 (UTC) Received: from [10.3.116.90] (ovpn-116-90.phx2.redhat.com [10.3.116.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1A22196B2; Thu, 17 Oct 2019 15:08:30 +0000 (UTC) Subject: Re: [PATCH] nvme: check for dynamic controller model before verifying cntlid To: Christoph Hellwig References: <1571257402-15747-1-git-send-email-dmilburn@redhat.com> <20191017145054.GA8622@lst.de> From: David Milburn Message-ID: <7aa48745-d729-3f8a-e657-cbaa588cc618@redhat.com> Date: Thu, 17 Oct 2019 10:08:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191017145054.GA8622@lst.de> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 17 Oct 2019 15:08:31 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_080832_419788_519DE5D1 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbusch@kernel.org, sagi@grimberg.me, linux-nvme@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Christoph, On 10/17/2019 09:50 AM, Christoph Hellwig wrote: > On Wed, Oct 16, 2019 at 03:23:22PM -0500, David Milburn wrote: >> - if (ctrl->cntlid != le16_to_cpu(id->cntlid)) { >> + if (id->ctrattr && (ctrl->cntlid != le16_to_cpu(id->cntlid))) { > > Where do get the all-Fs cntrlid? Identify Controller should return > the actual controller id, and the fabrics setup code also sets it up > to the return value of the connect command, which shouldn't be all-Fs > either. I see it in nvme_init_identify() after doing the nvme_identify_ctrl(), id->cntlid is FFFF causing the check to fail. There is a discussion in the NVMe over Fabrics spec, not specifically about identify, but with discover log page concerning dynamic vs static model and the value of cntlid, the target is a storage array. Thanks, David _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme